Skip to content

chore(deps): update Android SDK to v7.1.0 #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buenaflor merged 4 commits into from
Jan 3, 2024
Merged

chore(deps): update Android SDK to v7.1.0 #1788

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0d8cf4
chore: update flutter/scripts/update-android.sh to 7.1.0
web-flow Dec 21, 2023
493f8eb
Fix app start
buenaflor Dec 21, 2023
de8967b
format
buenaflor Dec 21, 2023
fd33383
Merge branch 'main' into deps/flutter/scripts/update-android.sh/7.1.0
buenaflor Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix app start
  • Loading branch information
@buenaflor
buenaflor committed Dec 21, 2023
commit 493f8eba028efae1c89bdf9d791f96c691c3972d
7 changes: 4 additions & 3 deletions flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ import io.sentry.SentryEvent
import io.sentry.SentryLevel
import io.sentry.SentryOptions
import io.sentry.android.core.ActivityFramesTracker
import io.sentry.android.core.AppStartState
import io.sentry.android.core.BuildConfig.VERSION_NAME
import io.sentry.android.core.LoadClass
import io.sentry.android.core.SentryAndroid
import io.sentry.android.core.SentryAndroidOptions
import io.sentry.android.core.performance.AppStartMetrics
import io.sentry.protocol.DebugImage
import io.sentry.protocol.SdkVersion
import io.sentry.protocol.SentryId
Expand Down Expand Up @@ -140,8 +140,9 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
result.success(null)
return
}
val appStartTime = AppStartState.getInstance().appStartTime
val isColdStart = AppStartState.getInstance().isColdStart

val appStartTime = AppStartMetrics.getInstance().appStartTimeSpan.startTimestamp
val isColdStart = AppStartMetrics.getInstance().appStartType == AppStartMetrics.AppStartType.COLD;

if (appStartTime == null) {
Log.w("Sentry", "App start won't be sent due to missing appStartTime")
Expand Down