Skip to content

Add isar breadcrumbs #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denrase merged 8 commits into from
Jan 8, 2024
Merged

Add isar breadcrumbs #1800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9a75165
update test expectations
denrase Jan 2, 2024
3225791
Merge branch 'main' into feat/isar-crumbs
denrase Jan 2, 2024
14dbc59
test collection crumbs
denrase Jan 2, 2024
3a73e59
test collection error crumbs
denrase Jan 2, 2024
e2ecda2
test error crumbs
denrase Jan 2, 2024
8ef99dc
add changelog entry
denrase Jan 2, 2024
6c65e57
test for warning level
denrase Jan 2, 2024
8bc4e9f
Merge branch 'main' into feat/isar-crumbs
denrase Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test collection crumbs
  • Loading branch information
@denrase
denrase committed Jan 2, 2024
commit 14dbc5901f956e5bc95f2496d46db30fc1dbd1af
178 changes: 178 additions & 0 deletions isar/test/sentry_isar_collection_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,19 @@ void main() {
expect(span?.throwable, error);
}

void verifyBreadcrumb(
String message,
Breadcrumb? crumb, {
String status = 'ok',
}) {
expect(
crumb?.message,
message,
);
expect(crumb?.type, 'query');
expect(crumb?.data?['status'], status);
}

group('add spans', () {
late Fixture fixture;

Expand Down Expand Up @@ -428,6 +441,167 @@ void main() {
);
});
});

group('add breadcrumbs', () {
late Fixture fixture;

setUp(() async {
fixture = Fixture();

when(fixture.hub.options).thenReturn(fixture.options);
when(fixture.hub.getSpan()).thenReturn(fixture.tracer);
when(fixture.hub.scope).thenReturn(fixture.scope);

await fixture.setUp();
});

tearDown(() async {
await fixture.tearDown();
});

test('clear adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().clear();
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('clear', breadcrumb);
});

test('count adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().count();
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('count', breadcrumb);
});

test('delete adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().delete(0);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('delete', breadcrumb);
});

test('deleteAll adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().deleteAll([0]);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('deleteAll', breadcrumb);
});

test('deleteAllByIndex adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().putByIndex('name', Person()..name = 'Joe');
await fixture.getSut().deleteAllByIndex('name', []);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[2];
verifyBreadcrumb('deleteAllByIndex', breadcrumb);
});

test('deleteByIndex adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().putByIndex('name', Person()..name = 'Joe');
await fixture.getSut().deleteByIndex('name', []);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[2];
verifyBreadcrumb('deleteByIndex', breadcrumb);
});

test('get adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().get(1);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('get', breadcrumb);
});

test('getAll adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().getAll([1]);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('getAll', breadcrumb);
});

test('getAllByIndex adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().getAllByIndex('name', []);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('getAllByIndex', breadcrumb);
});

test('getByIndex adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().getByIndex('name', []);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('getByIndex', breadcrumb);
});

test('getSize adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().getSize();
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('getSize', breadcrumb);
});

test('importJson adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().importJson([]);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('importJson', breadcrumb);
});

test('importJsonRaw adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
final query = fixture.getSut().buildQuery<Person>();
Uint8List jsonRaw = Uint8List.fromList([]);
await query.exportJsonRaw((raw) {
jsonRaw = Uint8List.fromList(raw);
});
await fixture.getSut().importJsonRaw(jsonRaw);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('importJsonRaw', breadcrumb);
});

test('put adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().put(Person());
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('put', breadcrumb);
});

test('putAll adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().putAll([Person()]);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('putAll', breadcrumb);
});

test('putAllByIndex adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().putAllByIndex('name', [Person()]);
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('putAllByIndex', breadcrumb);
});

test('putByIndex adds breadcrumb', () async {
await fixture.sentryIsar.writeTxn(() async {
await fixture.getSut().putByIndex('name', Person());
});
final breadcrumb = fixture.hub.scope.breadcrumbs[1];
verifyBreadcrumb('putByIndex', breadcrumb);
});
});
}

class Fixture {
Expand Down Expand Up @@ -476,4 +650,8 @@ class Fixture {
SentrySpan? getCreatedSpan() {
return tracer.children.last;
}

Breadcrumb? getCreatedBreadcrumb() {
return hub.scope.breadcrumbs.last;
}
}
2 changes: 1 addition & 1 deletion isar/test/sentry_isar_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ void main() {
});
});

group('adds breadcrumb', () {
group('adds breadcrumbs', () {
late Fixture fixture;

setUp(() async {
Expand Down