Skip to content

fix: sqflite tests #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
buenaflor wants to merge 1 commit into from
Closed

fix: sqflite tests #1806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sqflite/lib/src/sentry_database.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,4 +196,9 @@ class SentryDatabase extends SentryDatabaseExecutor implements Database {
}
});
}

@override
Future<T> readTransaction<T>(Future<T> Function(Transaction txn) action) {
return transaction((txn) => action(txn));
Copy link
Collaborator

@denrase denrase Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed this in #1807. We need to call the internal _database.readTransaction for this to be correct, no?

}
}