Skip to content

Accept Map<String, dynamic> in Hint class #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denrase merged 18 commits into from
Jan 23, 2024
Merged

Accept Map<String, dynamic> in Hint class #1807

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7dcf002
Change interal storage of `Hint` to `Map<String, dynamic>`
denrase Jan 8, 2024
dc4366b
Update factory ctor
denrase Jan 8, 2024
2607c5b
Add changelog entry
denrase Jan 8, 2024
cc285c1
update changelog
denrase Jan 8, 2024
2e2b51b
fix SentryDatabase implementation
denrase Jan 9, 2024
17cfecd
Merge branch 'main' into enha/accept-dynamic-values-in-hint
denrase Jan 9, 2024
b6513f0
add fallback for null values
denrase Jan 15, 2024
40946d3
Merge branch 'main' into enha/accept-dynamic-values-in-hint
denrase Jan 15, 2024
0d621ef
format
denrase Jan 15, 2024
0e87c12
revert dependency
denrase Jan 15, 2024
774ec13
bump ios deployment target to 12
denrase Jan 15, 2024
168f93d
Use fallback
denrase Jan 15, 2024
d1a426a
Remove sqflite fix from this PR
denrase Jan 15, 2024
be494a0
Merge branch 'main' into enha/accept-dynamic-values-in-hint
denrase Jan 17, 2024
b4a6410
revert version
denrase Jan 17, 2024
95c3dc1
change ios dep target back to ios 11
denrase Jan 23, 2024
1e56f4f
Merge branch 'main' into enha/accept-dynamic-values-in-hint
denrase Jan 23, 2024
2e9fe8f
update changelog
denrase Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add fallback for null values
  • Loading branch information
@denrase
denrase committed Jan 15, 2024
commit b6513f045406d18ca2250186483ddd0faa173a06
7 changes: 5 additions & 2 deletions dart/lib/src/hint.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,14 @@ class Hint {
// Key/Value Storage

void addAll(Map<String, dynamic> keysAndValues) {
_internalStorage.addAll(keysAndValues);
final withoutNullValues = keysAndValues.map(
(key, value) => MapEntry(key, value ?? "null")
);
_internalStorage.addAll(withoutNullValues);
}

void set(String key, dynamic value) {
_internalStorage[key] = value;
_internalStorage[key] = value ?? "null";
}

dynamic get(String key) {
Expand Down
17 changes: 17 additions & 0 deletions dart/test/hint_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,23 @@ void main() {
expect(sut.screenshot, attachment);
expect(sut.viewHierarchy, attachment);
});

test('Hint init with map null fallback', () {
final hint = Hint.withMap({'fixture-key': null});
expect("null", hint.get("fixture-key"));
});

test('Hint addAll with map null fallback', () {
final hint = Hint();
hint.addAll({'fixture-key': null});
expect("null", hint.get("fixture-key"));
});

test('Hint set with null value fallback', () {
final hint = Hint();
hint.set("fixture-key", null);
expect("null", hint.get("fixture-key"));
});
}

class Fixture {
Expand Down