Skip to content

loadContextsIntegration tests #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 12 commits into from
Nov 24, 2020
Merged

loadContextsIntegration tests #181

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1b5c498
add a loadContextsIntegration test
rxlabz Nov 23, 2020
fc06571
add an iOSPlatformChecker param to SentryFlutter.init
rxlabz Nov 23, 2020
d8cdbc0
more loadContextsIntegration tests
rxlabz Nov 24, 2020
f93812f
changelog
rxlabz Nov 24, 2020
05507c9
minor
rxlabz Nov 24, 2020
0376e46
minor
rxlabz Nov 24, 2020
9d5f84f
remove mock doublon
rxlabz Nov 24, 2020
10e2615
minor test refacto
rxlabz Nov 24, 2020
bc897d3
add tests : loadContextsIntegration is added only on ios
rxlabz Nov 24, 2020
3f38da6
remove useless import
rxlabz Nov 24, 2020
533b457
add a isWeb param to sentry_flutter_test
rxlabz Nov 24, 2020
1bb5ddf
minor
rxlabz Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor
  • Loading branch information
@rxlabz
rxlabz committed Nov 24, 2020
commit 05507c90b8394a280611d93fcf0a68a0c86e92f9
5 changes: 3 additions & 2 deletions flutter/lib/src/sentry_flutter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ mixin SentryFlutter {
OptionsConfiguration optionsConfiguration,
Function callback, {
PackageLoader packageLoader = _loadPackageInfo,
iOSPlatformChecker iOSPlatformChecker = _platformChecker,
iOSPlatformChecker iOSPlatformChecker = _iOSPlatformChecker,
}) async {
await Sentry.init((options) async {
await _initDefaultValues(
Expand Down Expand Up @@ -159,4 +159,5 @@ Future<PackageInfo> _loadPackageInfo() async {
return await PackageInfo.fromPlatform();
}

bool _platformChecker() => Platform.isIOS;
/// verify if the platform is iOS
bool _iOSPlatformChecker() => Platform.isIOS;
2 changes: 1 addition & 1 deletion flutter/test/default_integrations_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ void main() {
fixture.options.sdk.integrations.contains('nativeSdkIntegration'));
});

test('loadContextsIntegration adds integration on ios', () async {
test('loadContextsIntegration adds integration', () async {
_channel.setMockMethodCallHandler((MethodCall methodCall) async {});

final integration = loadContextsIntegration(fixture.options, _channel);
Expand Down