Skip to content

Add support for readTransaction in sqflite #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denrase merged 13 commits into from
Jan 17, 2024
Merged

Add support for readTransaction in sqflite #1819

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4cc63be
Add support for readTransaction
denrase Jan 15, 2024
a8d5518
Add changlog entry
denrase Jan 15, 2024
63aa2bb
format
denrase Jan 15, 2024
e33fe76
call transaction
denrase Jan 15, 2024
323c9d7
try to callm method with dynamic
denrase Jan 15, 2024
436e7f8
add comment
denrase Jan 15, 2024
8290633
Dynamically call `readTransaction` and wrap in span + add breadcrumb
denrase Jan 15, 2024
363a8df
ignore api doc
denrase Jan 15, 2024
5d3942a
update ignore
denrase Jan 16, 2024
852a30d
fix ignore directive
denrase Jan 16, 2024
ebc0768
Rename span context operation
denrase Jan 16, 2024
810a928
Add additional description
denrase Jan 16, 2024
fc5daf8
update changelog
denrase Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename span context operation
  • Loading branch information
@denrase
denrase committed Jan 16, 2024
commit ebc07682cc4ddc948d1184bf0574d2d322940080
2 changes: 1 addition & 1 deletion sqflite/lib/src/sentry_database.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class SentryDatabase extends SentryDatabaseExecutor implements Database {

static const _dbSqlTransactionOp = 'db.sql.transaction';

static const _dbSqlReadTransactionOp = 'db.sql.readTransaction';
static const _dbSqlReadTransactionOp = 'db.sql.read_transaction';

@internal
// ignore: public_member_api_docs
Expand Down
4 changes: 2 additions & 2 deletions sqflite/test/sentry_database_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ void main() {
expect(txn is SentrySqfliteTransaction, true);
});
final span = fixture.tracer.children.last;
expect(span.context.operation, 'db.sql.readTransaction');
expect(span.context.operation, 'db.sql.read_transaction');
expect(span.context.description, 'Transaction DB: $inMemoryDatabasePath');
expect(span.status, SpanStatus.ok());
expect(span.data[SentryDatabase.dbSystemKey], SentryDatabase.dbSystem);
Expand Down Expand Up @@ -158,7 +158,7 @@ void main() {

final breadcrumb = fixture.hub.scope.breadcrumbs.first;
expect(breadcrumb.message, 'Transaction DB: $inMemoryDatabasePath');
expect(breadcrumb.category, 'db.sql.readTransaction');
expect(breadcrumb.category, 'db.sql.read_transaction');
expect(breadcrumb.data?['status'], 'ok');
expect(
breadcrumb.data?[SentryDatabase.dbSystemKey],
Expand Down