Refrain from overwriting the span status for unfinished spans (#1577)

CHANGELOG.md

@@ -6,7 +6,10 @@
 
 - Mark exceptions not handled by the user as `handled: false` ([#1535](https://github.com/getsentry/sentry-dart/pull/1535))
   - This will affect your release health data, and is therefore considered a breaking change.
-
+- Refrain from overwriting the span status for unfinished spans ([#1577](https://github.com/getsentry/sentry-dart/pull/1577))
+  - Older self-hosted sentry instances will drop transactions containing unfinished spans.
+    - This change was introduced in [relay/#1690](https://github.com/getsentry/relay/pull/1690) and released with [22.12.0](https://github.com/getsentry/relay/releases/tag/22.12.0)
+
 ## 7.9.0
 
 ### Features

dart/lib/src/sentry_tracer.dart

@@ -85,15 +85,6 @@ class SentryTracer extends ISentrySpan {
       _children.removeWhere(
           (span) => !_hasSpanSuitableTimestamps(span, commonEndTimestamp));
 
-      // finish unfinished spans otherwise transaction gets dropped
-      final spansToBeFinished = _children.where((span) => !span.finished);
-      for (final span in spansToBeFinished) {
-        await span.finish(
-          status: SpanStatus.deadlineExceeded(),
-          endTimestamp: commonEndTimestamp,
-        );
-      }
-
       var _rootEndTimestamp = commonEndTimestamp;
       if (_trimEnd && children.isNotEmpty) {
         final childEndTimestamps = children

dart/test/sentry_tracer_test.dart

@@ -68,24 +68,7 @@ void main() {
       expect(sut.endTimestamp, endTimestamp);
     });
 
-    test(
-        'tracer finish sets given end timestamp to all children while finishing them',
-        () async {
-      final sut = fixture.getSut();
-
-      final childA = sut.startChild('operation-a', description: 'description');
-      final childB = sut.startChild('operation-b', description: 'description');
-      final endTimestamp = getUtcDateTime();
-
-      await sut.finish(endTimestamp: endTimestamp);
-      await childA.finish();
-      await childB.finish();
-
-      expect(childA.endTimestamp, endTimestamp);
-      expect(childB.endTimestamp, endTimestamp);
-    });
-
-    test('tracer finishes unfinished spans', () async {
+    test('tracer does not finish unfinished spans', () async {
       final sut = fixture.getSut();
       sut.startChild('child');
 
@@ -94,7 +77,8 @@ void main() {
       final tr = fixture.hub.captureTransactionCalls.first;
       final child = tr.transaction.spans.first;
 
-      expect(child.status.toString(), 'deadline_exceeded');
+      expect(child.status, isNull);
+      expect(child.endTimestamp, isNull);
     });
 
     test('tracer sets data to extra', () async {