Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jan 23, 2024

📜 Description

This is fixed here dart-lang/test#2177 and should successfully run the tests now.

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@buenaflor buenaflor changed the title fix: windows fix: windows test Jan 23, 2024
@codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f0d415) 88.57% compared to head (0818f67) 89.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
+ Coverage   88.57%   89.62%   +1.04%     
==========================================
  Files         206      125      -81     
  Lines        6880     3931    -2949     
==========================================
- Hits         6094     3523    -2571     
+ Misses        786      408     -378     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 374.66 ms 456.34 ms 81.68 ms
Size 6.33 MiB 7.26 MiB 950.38 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
408bdab 360.18 ms 434.92 ms 74.74 ms
5aab4c5 326.12 ms 378.82 ms 52.70 ms
86d4841 286.35 ms 372.43 ms 86.08 ms
6d317ea 303.46 ms 356.06 ms 52.60 ms
9f05645 349.43 ms 437.24 ms 87.81 ms
56810ff 309.72 ms 352.26 ms 42.54 ms
f79eecf 341.35 ms 388.98 ms 47.63 ms
c732386 316.84 ms 390.62 ms 73.78 ms
ebfead1 298.44 ms 374.28 ms 75.84 ms
8e133ad 360.08 ms 402.82 ms 42.74 ms

App size

Revision Plain With Sentry Diff
408bdab 6.27 MiB 7.20 MiB 959.07 KiB
5aab4c5 6.06 MiB 7.10 MiB 1.04 MiB
86d4841 6.15 MiB 7.13 MiB 1000.49 KiB
6d317ea 5.94 MiB 6.92 MiB 1001.74 KiB
9f05645 6.27 MiB 7.20 MiB 958.60 KiB
56810ff 5.94 MiB 6.92 MiB 1001.71 KiB
f79eecf 6.15 MiB 7.13 MiB 1000.07 KiB
c732386 6.26 MiB 7.20 MiB 958.78 KiB
ebfead1 6.06 MiB 7.03 MiB 989.24 KiB
8e133ad 6.06 MiB 7.03 MiB 990.29 KiB

Previous results on branch: fix/windows-test

Startup times

Revision Plain With Sentry Diff
d10ceff 392.98 ms 447.78 ms 54.80 ms

App size

Revision Plain With Sentry Diff
d10ceff 6.33 MiB 7.26 MiB 950.37 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.65 ms 1258.29 ms 21.64 ms
Size 8.32 MiB 9.38 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
48e79fd 1282.96 ms 1296.12 ms 13.17 ms
a510d1d 1277.04 ms 1291.57 ms 14.53 ms
df16b96 1255.24 ms 1259.40 ms 4.16 ms
49a149b 1296.47 ms 1320.20 ms 23.73 ms
0118295 1211.31 ms 1227.02 ms 15.71 ms
3f3ef0b 1223.73 ms 1237.67 ms 13.94 ms
b2cbbc8 1240.00 ms 1254.37 ms 14.37 ms
5603ab2 1268.47 ms 1280.73 ms 12.26 ms
d5f600b 1220.79 ms 1232.93 ms 12.14 ms
6e083bb 1244.33 ms 1264.60 ms 20.26 ms

App size

Revision Plain With Sentry Diff
48e79fd 8.16 MiB 9.15 MiB 1021.87 KiB
a510d1d 8.16 MiB 9.17 MiB 1.01 MiB
df16b96 8.10 MiB 9.16 MiB 1.06 MiB
49a149b 8.15 MiB 9.12 MiB 986.26 KiB
0118295 8.32 MiB 9.38 MiB 1.05 MiB
3f3ef0b 8.32 MiB 9.38 MiB 1.05 MiB
b2cbbc8 8.10 MiB 9.18 MiB 1.08 MiB
5603ab2 8.15 MiB 9.12 MiB 990.57 KiB
d5f600b 8.32 MiB 9.38 MiB 1.05 MiB
6e083bb 8.16 MiB 9.17 MiB 1.01 MiB

Previous results on branch: fix/windows-test

Startup times

Revision Plain With Sentry Diff
d10ceff 1202.77 ms 1227.96 ms 25.19 ms

App size

Revision Plain With Sentry Diff
d10ceff 8.32 MiB 9.38 MiB 1.06 MiB

@buenaflor buenaflor changed the title fix: windows test chore: reenable testing sentry-dart on windows Jan 24, 2024
@buenaflor buenaflor marked this pull request as ready for review January 24, 2024 17:29
@buenaflor buenaflor merged commit 920ec41 into main Jan 24, 2024
@buenaflor buenaflor deleted the fix/windows-test branch January 24, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants