Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 23, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fix: missing app's stack traces for Flutter errors

💡 Motivation and Context

FlutterError.onError errors were not showing app's stack traces.

💚 How did you test it?

running it

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

TODO: write tests for HubAdapter

@marandaneto marandaneto changed the title Fix: missing app's stack traces for flutter errors Fix: missing app's stack traces for Flutter errors Nov 23, 2020
@marandaneto marandaneto requested a review from rxlabz November 24, 2020 09:11
Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 8be475d into main Nov 24, 2020
@marandaneto marandaneto deleted the fix/missing-app-stacktraces-flutter-errors branch November 24, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants