Skip to content

Testflight #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
buenaflor merged 14 commits into from
Apr 10, 2024
Merged

Testflight #1938

buenaflor merged 14 commits into from
Apr 10, 2024

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Mar 18, 2024 •
edited
Loading

#skip-changelog

📜 Description

Setup an action to upload the iOS sample app to TestFlight.

💡 Motivation and Context

Closes #387

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase denrase changed the base branch from main to release/8.0.0 March 18, 2024 12:47
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c5de52d

@denrase denrase mentioned this pull request Mar 18, 2024
Closed
7 tasks
@denrase denrase changed the title Testflight (v8.0) Testflight Mar 18, 2024
@denrase denrase marked this pull request as ready for review March 18, 2024 14:19
@stefanosiano
Copy link
Contributor

stefanosiano commented Mar 18, 2024

hey @denrase
is there a braking change here? Why is it for v8?

philipphofmann
philipphofmann reviewed Mar 18, 2024
View reviewed changes
@denrase
Copy link
Collaborator Author

denrase commented Mar 19, 2024

@stefanosiano Needs iOS 12 to build, which we bump the SDK to in v8.

@denrase denrase requested a review from philipphofmann March 19, 2024 09:41
@denrase
Copy link
Collaborator Author

denrase commented Apr 9, 2024

@buenaflor Think we can merge this. WDYT?

buenaflor
buenaflor approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@buenaflor buenaflor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only thing left is to fix the red ci

@buenaflor buenaflor merged commit 6075021 into release/8.0.0 Apr 10, 2024
@buenaflor buenaflor deleted the feat/testflight-8.0 branch April 10, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buenaflor buenaflor buenaflor approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@philipphofmann philipphofmann Awaiting requested review from philipphofmann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@denrase @stefanosiano @philipphofmann @buenaflor