App start: native spans #2027
Merged
App start: native spans #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
buenaflor
commented
May 6, 2024
stefanosiano
reviewed
May 8, 2024
stefanosiano
reviewed
May 8, 2024
stefanosiano
approved these changes
May 8, 2024
Contributor
stefanosiano
left a comment
stefanosiano
left a comment
There was a problem hiding this comment.
just a detail, but good for the rest!
Contributor
Author
|
@stefanosiano I've updated the span description to |
stefanosiano
reviewed
May 9, 2024
Contributor
|
ok, last thing and can be merged 👍 |
Co-authored-by: Stefano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds native spans to app start transaction
💡 Motivation and Context
Improve app start transaction and give insight into the native layer times
💚 How did you test it?
Unit, Manual with spotlight
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps