Skip to content

Migrates to package:web and js_interop #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josh-burton wants to merge 5 commits into from
Closed

Migrates to package:web and js_interop #2064

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9838a9
feat: migrates to package:web and js_interop
josh-burton May 20, 2024
9a156fb
fix: enhances comment
josh-burton Jun 4, 2024
4266881
chore: Adds changelog
josh-burton Jun 4, 2024
7dfc42e
chore: formatting
josh-burton Jun 4, 2024
2bf4b4f
fix: changes min flutter version to 3.13.0 and dart sdk 3.1.0 to be c…
josh-burton Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: enhances comment
  • Loading branch information
@josh-burton
josh-burton committed Jun 4, 2024
commit 9a156fbf4b45c020b3ad0fcaf4e1c985a4b4055d
3 changes: 3 additions & 0 deletions flutter/lib/src/renderer/html_renderer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ bool get isCanvasKitRenderer {
return _windowFlutterCanvasKit != null;
}

// These values are set by the engine. They are used to determine if the
// application is using canvaskit or skwasm.
//
// See https://github.com/flutter/flutter/blob/414d9238720a3cde85475f49ce0ba313f95046f7/packages/flutter/lib/src/foundation/_capabilities_web.dart#L10
Copy link
Collaborator

@denrase denrase Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add the comment fron the link as decriptions.

// These values are set by the engine. They are used to determine if the
// application is using canvaskit or skwasm.
// 
// See https://github.com/flutter/flutter/blob/414d9238720a3cde85475f49ce0ba313f95046f7/packages/flutter/lib/src/foundation/_capabilities_web.dart#L10

Copy link
Contributor Author

@josh-burton josh-burton Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea

@JS('window.flutterCanvasKit')
external JSAny? get _windowFlutterCanvasKit;