-
-
Notifications
You must be signed in to change notification settings - Fork 277
chore(deps): update Android SDK to v7.11.0 #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update Android SDK to v7.11.0 #2144
Conversation
231fc8f to
8b9fa29
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
=======================================
Coverage 88.30% 88.31%
=======================================
Files 225 225
Lines 7773 7778 +5
=======================================
+ Hits 6864 6869 +5
Misses 909 909 ☔ View full report in Codecov by Sentry. |
8b9fa29 to
533aad3
Compare
|
I've added the sessions fix https://github.com/getsentry/sentry-dart/pull/2144/files#diff-cd61578f20b29db49fc80018b11c17cc056d93099388900ac1b85981f30d353e Could you @stefanosiano or @buenaflor review it. |
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
| .captured | ||
| .single as Uint8List; | ||
| final envelopeData = | ||
| verify(fixture.binding.captureEnvelope(captureAny, false)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
M: @buenaflor Can you add one new test, which check that the containsUnhandledException=true is read from the event and passed to the native call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added additional test cases
|
Thanks for the fixes, my change would not work! It looks good, I have only one comment about tests. |
krystofwoldrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good! Thank you.
Bumps flutter/scripts/update-android.sh from 7.10.0 to 7.11.0.
Auto-generated by a dependency updater.
Changelog
7.11.0
Features
Fixes
User.segment. Use a custom tag or context instead. (#3511)Dependencies