Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
249fad9
add captureFeedback methods
denrase Aug 13, 2024
76e733e
add should capture feedback as event test
denrase Aug 13, 2024
5595323
add sentry_feedback_test
denrase Aug 13, 2024
07815d8
update contexts test
denrase Aug 13, 2024
d3488c2
Merge branch 'main' into feat/capture-feedback
denrase Aug 13, 2024
684ef04
test before send feedback
denrase Aug 13, 2024
f3c8951
test hint and event processors
denrase Aug 13, 2024
95d8d9c
basic scope test
denrase Aug 13, 2024
ab350dc
test trace context and attachment behaviour
denrase Aug 13, 2024
26236e3
test sample rate for feedback and fix mock transport calls comparison
denrase Aug 13, 2024
bc22937
add hub tests
denrase Aug 13, 2024
58d83f9
add sentry tests
denrase Aug 13, 2024
74b5529
add changelog entry
denrase Aug 13, 2024
c86b10e
Merge branch 'main' into feat/capture-feedback
denrase Aug 19, 2024
9a7282c
cleanup + comments
denrase Aug 19, 2024
b238583
test envelope item for feedback
denrase Aug 19, 2024
8e12e8f
remove duplacte typedef
denrase Aug 19, 2024
ed773ef
fix test expectation
denrase Aug 19, 2024
ee71696
Deprecate captureUserFeedback
denrase Aug 19, 2024
4b403dd
update depraction info in cl
denrase Aug 19, 2024
b01cef2
format
denrase Aug 19, 2024
1733c9e
add missing option in test
denrase Aug 19, 2024
7b25235
run format
denrase Aug 19, 2024
d5c1f0d
organize imports
denrase Aug 19, 2024
4785da9
add missing method
denrase Aug 19, 2024
4ae6696
fix test epectation
denrase Aug 19, 2024
06a4a5f
ignore deprecations internally
denrase Aug 19, 2024
4bb3ceb
add to integration test, fix analyze errors
denrase Aug 19, 2024
34b2626
Merge branch 'main' into feat/capture-feedback
denrase Sep 5, 2024
5a18fdf
fix cl
denrase Sep 5, 2024
4f368c9
Merge branch 'main' into feat/capture-feedback
denrase Sep 23, 2024
995d288
disable fixture.options.automatedTestMode
denrase Sep 23, 2024
3114a70
update test
denrase Sep 23, 2024
55c6870
fix cl
denrase Sep 23, 2024
f1a8281
Add `SentryFeedbackWidget` (#2240)
denrase Sep 23, 2024
b52e3fc
Merge branch 'main' into feat/capture-feedback
denrase Oct 1, 2024
eb98dd2
fix cl
denrase Oct 1, 2024
67aec30
Merge branch 'main' into feat/capture-feedback
buenaflor Oct 10, 2024
02b7b75
Update CHANGELOG.md
buenaflor Oct 10, 2024
f187ee9
Update CHANGELOG.md
buenaflor Oct 10, 2024
b0b273c
Update CHANGELOG.md
buenaflor Oct 10, 2024
48bc130
Update CHANGELOG.md
buenaflor Oct 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test sample rate for feedback and fix mock transport calls comparison
  • Loading branch information
denrase committed Aug 13, 2024
commit 26236e3453d9b4c8fb72326f02c6122fe25354ce
2 changes: 1 addition & 1 deletion dart/lib/src/sentry_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class SentryClient {
return _emptySentryId;
}

if (_sampleRate()) {
if (_sampleRate() && event.type != 'feedback') {
_options.recorder
.recordLostEvent(DiscardReason.sampleRate, _getCategory(event));
_options.logger(
Expand Down
2 changes: 1 addition & 1 deletion dart/test/mocks/mock_transport.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class MockTransport implements Transport {
}

bool called(int calls) {
return calls == calls;
return _calls == calls;
}

@override
Expand Down
15 changes: 12 additions & 3 deletions dart/test/sentry_client_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1037,21 +1037,30 @@ void main() {
final client = fixture.getSut(sampleRate: 1.0);
await client.captureEvent(fakeEvent);

expect((fixture.transport).called(1), true);
expect(fixture.transport.called(1), true);
});

test('do not capture event, sample rate is 0% disabled', () async {
final client = fixture.getSut(sampleRate: 0.0);
await client.captureEvent(fakeEvent);

expect((fixture.transport).called(0), true);
expect(fixture.transport.called(0), true);
});

test('captures event, sample rate is null, disabled', () async {
final client = fixture.getSut();
await client.captureEvent(fakeEvent);

expect((fixture.transport).called(1), true);
expect(fixture.transport.called(1), true);
});

test('capture feedback event, sample rate is 0% disabled', () async {
final client = fixture.getSut(sampleRate: 0.0);

final fakeFeedback = fixture.fakeFeedback();
await client.captureFeedback(fakeFeedback);

expect(fixture.transport.called(1), true);
});
});

Expand Down