Skip to content

Refactoring: Dart Nullsafety #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 33 commits into from
Feb 24, 2021
Merged

Refactoring: Dart Nullsafety #298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
bc65a42
Update dependencies + fix tests
ueman Feb 10, 2021
c6b35e0
Remove unused code
ueman Feb 10, 2021
4dc480b
Migration Hints
ueman Feb 10, 2021
88eb3c6
add more type annotations + make api more nullsafety friendly
ueman Feb 10, 2021
ff296d0
null safety migration
ueman Feb 10, 2021
35b663d
Rewritten test + fixed linter warnings
ueman Feb 13, 2021
713b05b
Fixed more test which were broken
ueman Feb 13, 2021
c24a96d
Fix tests
ueman Feb 14, 2021
d722a8c
Don't build CI on Dart stable
ueman Feb 14, 2021
437fc1c
Fixed test + some more null safety refactorings
ueman Feb 14, 2021
9133b3b
build flutter only on beta
ueman Feb 15, 2021
b15c136
fix example
ueman Feb 15, 2021
3d4a513
make sure the Flutter Sentry SDK compiles
ueman Feb 15, 2021
d594922
DebugImage.type is required -> non-nullable
ueman Feb 15, 2021
42a619c
add changelog
ueman Feb 15, 2021
5201270
Update dart/lib/src/sentry_options.dart
ueman Feb 17, 2021
a41c4a7
Merge remote-tracking branch 'upstream/main' into feature/nullsafety
ueman Feb 20, 2021
5276086
Apply improvements and suggestions from PR review
ueman Feb 20, 2021
39c6a2a
Use stable null safe release in Flutter
ueman Feb 20, 2021
9a7328b
Some smaller fixes
ueman Feb 20, 2021
5c0ddbf
use correct dart sdk
ueman Feb 20, 2021
95508d6
Use nullable lists/maps :(
ueman Feb 20, 2021
3638f43
fix
ueman Feb 20, 2021
44a8206
Update dart/lib/src/scope.dart
ueman Feb 22, 2021
3b2b6dd
Add PR feedback
ueman Feb 22, 2021
699b31a
Merge remote-tracking branch 'origin/feature/nullsafety' into feature…
ueman Feb 22, 2021
7635d4e
fix typo
ueman Feb 22, 2021
006fb0c
Merge remote-tracking branch 'upstream/feat/null-safety' into feature…
ueman Feb 22, 2021
1703333
fix problems caused by merge
ueman Feb 22, 2021
7ea8a89
PR Feedback
ueman Feb 23, 2021
1aacadb
Make SentryLevel nullable again
ueman Feb 23, 2021
7308de7
Remove default values
ueman Feb 23, 2021
83bc406
PR Feedback
ueman Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make SentryLevel nullable again
  • Loading branch information
@ueman
ueman committed Feb 23, 2021
commit 1aacadb997704b51b14920fd98e94832a4afeb22
2 changes: 1 addition & 1 deletion dart/lib/src/hub.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class Hub {
/// Captures the message.
Future<SentryId> captureMessage(
String? message, {
SentryLevel level = SentryLevel.info,
SentryLevel? level = SentryLevel.info,
String? template,
List<dynamic>? params,
dynamic hint,
Expand Down
2 changes: 1 addition & 1 deletion dart/lib/src/hub_adapter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class HubAdapter implements Hub {
@override
Future<SentryId> captureMessage(
String? message, {
SentryLevel level = SentryLevel.info,
SentryLevel? level = SentryLevel.info,
String? template,
List? params,
dynamic hint,
Expand Down
2 changes: 1 addition & 1 deletion dart/lib/src/sentry.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class Sentry {

static Future<SentryId> captureMessage(
String? message, {
SentryLevel level = SentryLevel.info,
SentryLevel? level = SentryLevel.info,
String? template,
List<dynamic>? params,
dynamic hint,
Expand Down
2 changes: 1 addition & 1 deletion dart/lib/src/sentry_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class SentryClient {
/// Reports the [template]
Future<SentryId> captureMessage(
String? formatted, {
SentryLevel level = SentryLevel.info,
SentryLevel? level = SentryLevel.info,
String? template,
List<dynamic>? params,
Scope? scope,
Expand Down
4 changes: 2 additions & 2 deletions dart/test/mocks/mock_hub.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class MockHub implements Hub {
@override
Future<SentryId> captureMessage(
String? message, {
SentryLevel level = SentryLevel.info,
SentryLevel? level = SentryLevel.info,
String? template,
List? params,
dynamic hint,
Expand Down Expand Up @@ -99,7 +99,7 @@ class CaptureExceptionCall {

class CaptureMessageCall {
final String? message;
final SentryLevel level;
final SentryLevel? level;
final String? template;
final List? params;
final dynamic hint;
Expand Down
4 changes: 2 additions & 2 deletions dart/test/mocks/mock_sentry_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class MockSentryClient implements SentryClient {
@override
Future<SentryId> captureMessage(
String? formatted, {
SentryLevel level = SentryLevel.info,
SentryLevel? level = SentryLevel.info,
String? template,
List? params,
Scope? scope,
Expand Down Expand Up @@ -94,7 +94,7 @@ class CaptureExceptionCall {

class CaptureMessageCall {
final String? formatted;
final SentryLevel level;
final SentryLevel? level;
final String? template;
final List? params;
final Scope? scope;
Expand Down