Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/analyze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
if: ${{ inputs.package == 'flutter' }}
working-directory: ${{ inputs.package }}
run: |
sed -i.bak 's|sentry:.*|sentry:\n path: /github/workspace/dart|g' pubspec.yaml
sed -i.bak 's|sentry:.*|sentry:\n path: /github/workspace/packages/dart|g' pubspec.yaml
- uses: axel-op/dart-package-analyzer@56afb7e6737bd2b7cee05382ae7f0e8111138080 # pin@v3
id: analysis
with:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/dart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
- '.github/workflows/analyze.yml'
- '.github/actions/dart-test/**'
- '.github/actions/coverage/**'
- 'dart/**'
- 'packages/dart/**'

jobs:
cancel-previous-workflow:
Expand Down Expand Up @@ -45,24 +45,24 @@ jobs:

- uses: ./.github/actions/dart-test
with:
directory: dart
directory: packages/dart

- uses: ./.github/actions/coverage
if: runner.os == 'Linux' && matrix.sdk == 'stable'
with:
token: ${{ secrets.CODECOV_TOKEN }}
directory: dart
directory: packages/dart
coverage: sentry
min-coverage: 85

- name: Build example
working-directory: dart/example
working-directory: packages/dart/example
run: |
dart pub get
dart compile aot-snapshot bin/example.dart

analyze:
uses: ./.github/workflows/analyze.yml
with:
package: dart
package: packages/dart
panaThreshold: 87
11 changes: 1 addition & 10 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
.packages
.dart_tool/
build/
packages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you knwo why packages was previously in gitignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was added 8 years ago, so it might have been some Dart/Flutter specific thing that was still an issue back then.

today packages is used a lot, e.g https://github.com/flame-engine/flame/

pubspec.lock
.pub/
.idea/libraries
Expand All @@ -17,15 +16,7 @@ build/
.fvmrc

.test_coverage.dart
dart/coverage/*
logging/coverage/*
dio/coverage/*
file/coverage/*
flutter/coverage/*
sqflite/coverage/*
drift/coverage/*
hive/coverage/*
isar/coverage/*
packages/**/coverage/*

pubspec.lock
Podfile.lock
Expand Down
1 change: 0 additions & 1 deletion dart/CHANGELOG.md

This file was deleted.

2 changes: 1 addition & 1 deletion dio/dartdoc_options.yaml
2 changes: 1 addition & 1 deletion dio/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
sentry:
path: ../dart
path: ../packages/dart
2 changes: 1 addition & 1 deletion drift/dartdoc_options.yaml
2 changes: 1 addition & 1 deletion drift/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
sentry:
path: ../dart
path: ../packages/dart
2 changes: 1 addition & 1 deletion e2e_test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ environment:
dependencies:
sentry:
path:
./../dart
./../packages/dart
http: ^0.13.0

dev_dependencies:
Expand Down
2 changes: 1 addition & 1 deletion file/dartdoc_options.yaml
2 changes: 1 addition & 1 deletion file/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
sentry:
path: ../dart
path: ../packages/dart
2 changes: 1 addition & 1 deletion firebase_remote_config/dartdoc_options.yaml
2 changes: 1 addition & 1 deletion firebase_remote_config/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
sentry:
path: ../dart
path: ../packages/dart
2 changes: 1 addition & 1 deletion flutter/dartdoc_options.yaml
2 changes: 1 addition & 1 deletion flutter/example/integration_test/profiling_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import 'dart:io';

import 'package:flutter_test/flutter_test.dart';
import 'package:sentry_flutter/sentry_flutter.dart';
import '../../../dart/test/mocks/mock_transport.dart';
import '../../../packages/dart/test/mocks/mock_transport.dart';

void main() {
final transport = MockTransport();
Expand Down
2 changes: 1 addition & 1 deletion flutter/example/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependency_overrides:
sentry:
path: ../../dart
path: ../../packages/dart
sentry_flutter:
path: ../
sentry_dio:
Expand Down
2 changes: 1 addition & 1 deletion flutter/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
sentry:
path: ../dart
path: ../packages/dart
2 changes: 1 addition & 1 deletion hive/dartdoc_options.yaml
2 changes: 1 addition & 1 deletion hive/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
sentry:
path: ../dart
path: ../packages/dart
2 changes: 1 addition & 1 deletion isar/dartdoc_options.yaml
2 changes: 1 addition & 1 deletion isar/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
sentry:
path: ../dart
path: ../packages/dart
2 changes: 1 addition & 1 deletion link/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
sentry:
path: ../dart
path: ../packages/dart
2 changes: 1 addition & 1 deletion logging/dartdoc_options.yaml
2 changes: 1 addition & 1 deletion logging/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
sentry:
path: ../dart
path: ../packages/dart
7 changes: 7 additions & 0 deletions melos.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
name: sentry_dart_workspace
packages:
- 'packages/**'

ide:
intellij:
moduleNamePrefix: ''
2 changes: 1 addition & 1 deletion metrics/prepare-dart.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ cat <<EOF >>"$pubspec"

dependency_overrides:
sentry:
path: ../../dart
path: ../../packages/dart

EOF

Expand Down
2 changes: 1 addition & 1 deletion metrics/prepare.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ cat <<EOF >>"$pubspec"

dependency_overrides:
sentry:
path: ../../dart
path: ../../packages/dart
sentry_flutter:
path: ../../flutter

Expand Down
2 changes: 1 addition & 1 deletion min_version_test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ dependency_overrides:
flutter:
sdk: flutter
sentry:
path: ../dart
path: ../packages/dart
sentry_flutter:
path: ../flutter
sentry_dio:
Expand Down
File renamed without changes.
1 change: 1 addition & 0 deletions packages/dart/CHANGELOG.md
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 4 additions & 0 deletions packages/dart/example/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# melos_managed_dependency_overrides: sentry
dependency_overrides:
sentry:
path: ..
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 4 additions & 0 deletions packages/dart/example_web/pubspec_overrides.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# melos_managed_dependency_overrides: sentry
dependency_overrides:
sentry:
path: ..
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Loading
Loading