Skip to content

Implement useSentryUser parameter in SentryFeedbackWidget #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denrase merged 5 commits into from
Aug 20, 2025
Merged

Implement useSentryUser parameter in SentryFeedbackWidget #3180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
307bf8d
Implement missing `useSentryUser` parameter in `SentryFeedbackWidget`
Aug 17, 2025
a9f3057
Refactor test stubs to fixture and fix tests broken by `useSentryUser…
Aug 18, 2025
f087e0d
Add tests for `SentryFeedbackWidget` prefill with `useSentryUser` param
Aug 18, 2025
0211e70
Merge remote-tracking branch 'upstream/main'
Aug 20, 2025
b861b1a
Add changelog entry for `useSentryUser` prefill logic
Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor test stubs to fixture and fix tests broken by `useSentryUser… 
…` feature
  • Loading branch information
inti7ary committed Aug 18, 2025
commit a9f3057323021c7184bce18a8d915dc6c6f271a9
12 changes: 6 additions & 6 deletions packages/flutter/test/feedback/sentry_feedback_widget_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@ void main() {
final mockBinding = MockSentryNativeBinding();
when(mockBinding.supportsReplay).thenReturn(true);
when(fixture.hub.scope).thenReturn(fixture.scope);
when(fixture.hub.configureScope(any)).thenAnswer((invocation) {
final callback = invocation.positionalArguments.first;
callback(fixture.scope);
return null;
});

final replayId = SentryId.fromId('1988bb1b6f0d4c509e232f0cb9aaeaea');
when(mockBinding.captureReplay()).thenAnswer((_) async => replayId);

Expand Down Expand Up @@ -768,7 +764,11 @@ class Fixture {
hint: anyNamed('hint'),
withScope: anyNamed('withScope'),
)).thenAnswer((_) async => SentryId.empty());

when(hub.configureScope(any)).thenAnswer((invocation) {
final callback = invocation.positionalArguments.first;
callback(scope);
return null;
});
SentryFeedbackWidget.pendingAssociatedEventId = null;
SentryFeedbackWidget.clearPreservedData();
}
Expand Down
7 changes: 7 additions & 0 deletions packages/flutter/test/screenshot/sentry_screenshot_widget_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,14 @@ void main() {
options.navigatorKey = navigatorKey;

var hub = mocks.MockHub();
late var scope = Scope(options);

when(hub.options).thenReturn(options);
when(hub.configureScope(any)).thenAnswer((invocation) {
final callback = invocation.positionalArguments.first;
callback(scope);
return null;
});

await tester.pumpWidget(
MaterialApp(
Expand Down