-
-
Notifications
You must be signed in to change notification settings - Fork 277
[Span First #2]: Add envelope type to Dart layer #3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/span-first #3366 +/- ##
==================================================
Coverage ? 88.37%
==================================================
Files ? 290
Lines ? 9834
Branches ? 0
==================================================
Hits ? 8691
Misses ? 1143
Partials ? 0 ☔ View full report in Codecov by Sentry. |
| /// Create a [SentryEnvelope] containing raw span data payload. | ||
| /// This is used by the span buffer to send pre-encoded spans. | ||
| @internal | ||
| factory SentryEnvelope.fromSpansData( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not actually used yet but will be used by the span buffer (impl TBD)
denrase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Span First initiative
💡 Motivation and Context
Add support for span envelope items in Dart's transport layer (for Android we need to change the native SDKs directly - iOS works already without modification)
Also the API
fromSpansDatais when we add the spans from the buffer similar to logs💚 How did you test it?
Unit test and manual tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
#skip-changelog