Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Nov 24, 2025

📜 Description

Span First initiative

💡 Motivation and Context

Add support for span envelope items in Dart's transport layer (for Android we need to change the native SDKs directly - iOS works already without modification)

Also the API fromSpansData is when we add the spans from the buffer similar to logs

💚 How did you test it?

Unit test and manual tests

image

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat/span-first@de96551). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             feat/span-first    #3366   +/-   ##
==================================================
  Coverage                   ?   88.37%           
==================================================
  Files                      ?      290           
  Lines                      ?     9834           
  Branches                   ?        0           
==================================================
  Hits                       ?     8691           
  Misses                     ?     1143           
  Partials                   ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review November 25, 2025 10:45
/// Create a [SentryEnvelope] containing raw span data payload.
/// This is used by the span buffer to send pre-encoded spans.
@internal
factory SentryEnvelope.fromSpansData(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not actually used yet but will be used by the span buffer (impl TBD)

@buenaflor buenaflor requested a review from denrase November 25, 2025 16:05
Base automatically changed from feat/span-protocol to feat/span-first November 26, 2025 16:27
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@buenaflor buenaflor merged commit 471badc into feat/span-first Nov 27, 2025
132 of 134 checks passed
@buenaflor buenaflor deleted the feat/spans/dart-protocol branch November 27, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants