-
-
Notifications
You must be signed in to change notification settings - Fork 277
Add 'transaction' and 'breadcrumbs' in event #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+1 to get this merged |
yjbanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transaction and breadcrumbs LGTM. Let's leave contexts out of this PR. #40 is adding a fully schemed version of it.
|
@yjbanov The 'contexts' was discarded. |
|
Thanks, just a couple more things I noticed. |
|
@yjbanov Thanks for reviewing. Request changes applied. |
|
@yjbanov Looked up the |
|
Would love to have this and "Context" merged, as currently reporting is quite light :) |
Would you mind trying |
|
@yjbanov Sorrry for my late reply. I have updated the commits, again. |
|
LGTM! Thank you for contributing this feature! |
ref docs:
transaction: https://docs.sentry.io/development/sdk-dev/event-payloads/#optional-attributes
contexts: https://docs.sentry.io/development/sdk-dev/event-payloads/contexts/
breadcrumbs: https://docs.sentry.io/development/sdk-dev/event-payloads/breadcrumbs/
There is a related pr #40 when i create this pr. In my opinion, the
Eventclass should know nothing about what thecontextshave, so i did not create the wrapper class for theos,device,etc which it might contains.