PR Feedback

logging/lib/src/logging_integration.dart

@@ -10,10 +10,10 @@ import 'extension.dart';
 class LoggingIntegration extends Integration<SentryOptions> {
   /// Creates the [LoggingIntegration].
   ///
-  /// Setting [logExceptionAsEvent] to true (default) captures all
-  /// messages with errors as an [SentryEvent] instead of an [Breadcrumb].
-  /// Setting [logExceptionAsEvent] to false captures everything as
-  /// [Breadcrumb]s.
+  /// All log events equal or higher than [minBreadcrumbLevel] are recorded as a
+  /// [Breadcrumb].
+  /// All log events equal or higher than [minEventLevel] are recorded as a
+  /// [SentryEvent].
   LoggingIntegration({
     Level minBreadcrumbLevel = Level.INFO,
     Level minEventLevel = Level.SEVERE,
@@ -56,7 +56,7 @@ class LoggingIntegration extends Integration<SentryOptions> {
   }
 
   bool _isLoggable(Level logLevel, Level minLevel) {
-    return logLevel > minLevel;
+    return logLevel >= minLevel;
   }
 
   void _onLog(LogRecord record) async {

logging/test/logging_integration_test.dart

@@ -40,9 +40,7 @@ void main() {
     await sut.call(fixture.hub, fixture.options);
 
     final log = Logger('FooBarLogger');
-    log.warning(
-      'A log message',
-    );
+    log.warning('A log message');
 
     expect(fixture.hub.events.length, 0);
     expect(fixture.hub.breadcrumbs.length, 1);
@@ -58,14 +56,23 @@ void main() {
     expect(crumb.type, 'debug');
   });
 
+  test('logger gets recorded if level equal minlevel', () async {
+    final sut = fixture.createSut(minBreadcrumbLevel: Level.INFO);
+    await sut.call(fixture.hub, fixture.options);
+
+    final log = Logger('FooBarLogger');
+    log.info('A log message');
+
+    expect(fixture.hub.events.length, 0);
+    expect(fixture.hub.breadcrumbs.length, 1);
+  });
+
   test('logger gets not recorded if level under minlevel', () async {
     final sut = fixture.createSut(minBreadcrumbLevel: Level.SEVERE);
     await sut.call(fixture.hub, fixture.options);
 
     final log = Logger('FooBarLogger');
-    log.warning(
-      'A log message',
-    );
+    log.warning('A log message');
 
     expect(fixture.hub.events.length, 0);
     expect(fixture.hub.breadcrumbs.length, 0);
@@ -95,6 +102,24 @@ void main() {
     expect(fixture.hub.events.first.stackTrace, stackTrace);
   });
 
+  test('exception is recorded as event if minEventLevel equal minlevel',
+      () async {
+    final sut = fixture.createSut(minEventLevel: Level.INFO);
+    await sut.call(fixture.hub, fixture.options);
+
+    final exception = Exception('foo bar');
+    final stackTrace = StackTrace.current;
+
+    final log = Logger('FooBarLogger');
+    log.info(
+      'A log message',
+      exception,
+      stackTrace,
+    );
+    expect(fixture.hub.events.length, 1);
+    expect(fixture.hub.events.first.event.breadcrumbs, null);
+  });
+
   test('exception is not recorded as event if minEventLevel under minlevel',
       () async {
     final sut = fixture.createSut(minEventLevel: Level.SEVERE);