didPush starts transaction

flutter/lib/src/navigation/sentry_navigator_observer.dart

@@ -44,6 +44,7 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
 
   final Hub _hub;
   final bool _setRouteNameAsTransaction;
+  ISentrySpan? _transaction;
 
   @override
   void didPush(Route<dynamic> route, Route<dynamic>? previousRoute) {
@@ -54,6 +55,7 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
       from: previousRoute?.settings,
       to: route.settings,
     );
+    _startTransaction(route.settings.name, route.settings.arguments);
   }
 
   @override
@@ -100,6 +102,18 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
       });
     }
   }
+
+  void _startTransaction(String? name, Object? arguments) {
+    _transaction = _hub.startTransaction(
+      name ?? 'unknown',
+      'ui.load',
+      bindToScope: true,
+    );
+    if (arguments != null) {
+      _transaction?.setData('route_settings_arguments', arguments);
+    }
+  }
+
 }
 
 /// This class makes it easier to record breadcrumbs for events of Flutters

flutter/pubspec.yaml

@@ -17,6 +17,7 @@ dependencies:
   package_info_plus: ^1.0.0
 
 dev_dependencies:
+  build_runner: ^2.1.5
   flutter_test:
     sdk: flutter
   mockito: ^5.0.16

flutter/test/mocks.mocks.dart

@@ -1,29 +1,32 @@
-// Mocks generated by Mockito 5.0.7 from annotations
-// in sentry_flutter/example/ios/.symlinks/plugins/sentry_flutter/test/mocks.dart.
+// Mocks generated by Mockito 5.0.16 from annotations
+// in sentry_flutter/test/mocks.dart.
 // Do not manually edit this file.
 
-import 'dart:async' as _i4;
+import 'dart:async' as _i5;
 
 import 'package:mockito/mockito.dart' as _i1;
 import 'package:sentry/src/hub.dart' as _i3;
-import 'package:sentry/src/protocol/breadcrumb.dart' as _i7;
-import 'package:sentry/src/protocol/sentry_event.dart' as _i5;
-import 'package:sentry/src/protocol/sentry_id.dart' as _i2;
-import 'package:sentry/src/protocol/sentry_level.dart' as _i6;
-import 'package:sentry/src/sentry_client.dart' as _i8;
-import 'package:sentry/src/sentry_envelope.dart' as _i10;
-import 'package:sentry/src/transport/transport.dart' as _i9;
+import 'package:sentry/src/protocol.dart' as _i2;
+import 'package:sentry/src/sentry_client.dart' as _i7;
+import 'package:sentry/src/sentry_envelope.dart' as _i9;
+import 'package:sentry/src/sentry_user_feedback.dart' as _i6;
+import 'package:sentry/src/tracing.dart' as _i4;
+import 'package:sentry/src/transport/transport.dart' as _i8;
 
+// ignore_for_file: avoid_redundant_argument_values
+// ignore_for_file: avoid_setters_without_getters
 // ignore_for_file: comment_references
-// ignore_for_file: unnecessary_parenthesis
-
+// ignore_for_file: implementation_imports
+// ignore_for_file: invalid_use_of_visible_for_testing_member
 // ignore_for_file: prefer_const_constructors
+// ignore_for_file: unnecessary_parenthesis
+// ignore_for_file: camel_case_types
 
-// ignore_for_file: avoid_redundant_argument_values
+class _FakeSentryId_0 extends _i1.Fake implements _i2.SentryId {}
 
-class _FakeSentryId extends _i1.Fake implements _i2.SentryId {}
+class _FakeHub_1 extends _i1.Fake implements _i3.Hub {}
 
-class _FakeHub extends _i1.Fake implements _i3.Hub {}
+class _FakeISentrySpan_2 extends _i1.Fake implements _i4.ISentrySpan {}
 
 /// A class which mocks [Hub].
 ///
@@ -40,9 +43,9 @@ class MockHub extends _i1.Mock implements _i3.Hub {
   @override
   _i2.SentryId get lastEventId =>
       (super.noSuchMethod(Invocation.getter(#lastEventId),
-          returnValue: _FakeSentryId()) as _i2.SentryId);
+          returnValue: _FakeSentryId_0()) as _i2.SentryId);
   @override
-  _i4.Future<_i2.SentryId> captureEvent(_i5.SentryEvent? event,
+  _i5.Future<_i2.SentryId> captureEvent(_i2.SentryEvent? event,
           {dynamic stackTrace, dynamic hint, _i3.ScopeCallback? withScope}) =>
       (super.noSuchMethod(
               Invocation.method(#captureEvent, [
@@ -52,10 +55,10 @@ class MockHub extends _i1.Mock implements _i3.Hub {
                 #hint: hint,
                 #withScope: withScope
               }),
-              returnValue: Future<_i2.SentryId>.value(_FakeSentryId()))
-          as _i4.Future<_i2.SentryId>);
+              returnValue: Future<_i2.SentryId>.value(_FakeSentryId_0()))
+          as _i5.Future<_i2.SentryId>);
   @override
-  _i4.Future<_i2.SentryId> captureException(dynamic throwable,
+  _i5.Future<_i2.SentryId> captureException(dynamic throwable,
           {dynamic stackTrace, dynamic hint, _i3.ScopeCallback? withScope}) =>
       (super.noSuchMethod(
               Invocation.method(#captureException, [
@@ -65,11 +68,11 @@ class MockHub extends _i1.Mock implements _i3.Hub {
                 #hint: hint,
                 #withScope: withScope
               }),
-              returnValue: Future<_i2.SentryId>.value(_FakeSentryId()))
-          as _i4.Future<_i2.SentryId>);
+              returnValue: Future<_i2.SentryId>.value(_FakeSentryId_0()))
+          as _i5.Future<_i2.SentryId>);
   @override
-  _i4.Future<_i2.SentryId> captureMessage(String? message,
-          {_i6.SentryLevel? level,
+  _i5.Future<_i2.SentryId> captureMessage(String? message,
+          {_i2.SentryLevel? level,
           String? template,
           List<dynamic>? params,
           dynamic hint,
@@ -84,40 +87,90 @@ class MockHub extends _i1.Mock implements _i3.Hub {
                 #hint: hint,
                 #withScope: withScope
               }),
-              returnValue: Future<_i2.SentryId>.value(_FakeSentryId()))
-          as _i4.Future<_i2.SentryId>);
+              returnValue: Future<_i2.SentryId>.value(_FakeSentryId_0()))
+          as _i5.Future<_i2.SentryId>);
+  @override
+  _i5.Future<void> captureUserFeedback(_i6.SentryUserFeedback? userFeedback) =>
+      (super.noSuchMethod(
+          Invocation.method(#captureUserFeedback, [userFeedback]),
+          returnValue: Future<void>.value(),
+          returnValueForMissingStub: Future<void>.value()) as _i5.Future<void>);
   @override
-  void addBreadcrumb(_i7.Breadcrumb? crumb, {dynamic hint}) => super
+  void addBreadcrumb(_i2.Breadcrumb? crumb, {dynamic hint}) => super
       .noSuchMethod(Invocation.method(#addBreadcrumb, [crumb], {#hint: hint}),
           returnValueForMissingStub: null);
   @override
-  void bindClient(_i8.SentryClient? client) =>
+  void bindClient(_i7.SentryClient? client) =>
       super.noSuchMethod(Invocation.method(#bindClient, [client]),
           returnValueForMissingStub: null);
   @override
   _i3.Hub clone() => (super.noSuchMethod(Invocation.method(#clone, []),
-      returnValue: _FakeHub()) as _i3.Hub);
+      returnValue: _FakeHub_1()) as _i3.Hub);
   @override
-  _i4.Future<void> close() => (super.noSuchMethod(Invocation.method(#close, []),
-      returnValue: Future<void>.value(null),
-      returnValueForMissingStub: Future.value()) as _i4.Future<void>);
+  _i5.Future<void> close() => (super.noSuchMethod(Invocation.method(#close, []),
+      returnValue: Future<void>.value(),
+      returnValueForMissingStub: Future<void>.value()) as _i5.Future<void>);
   @override
   void configureScope(_i3.ScopeCallback? callback) =>
       super.noSuchMethod(Invocation.method(#configureScope, [callback]),
           returnValueForMissingStub: null);
+  @override
+  _i4.ISentrySpan startTransaction(String? name, String? operation,
+          {String? description,
+          bool? bindToScope,
+          Map<String, dynamic>? customSamplingContext}) =>
+      (super.noSuchMethod(
+          Invocation.method(#startTransaction, [
+            name,
+            operation
+          ], {
+            #description: description,
+            #bindToScope: bindToScope,
+            #customSamplingContext: customSamplingContext
+          }),
+          returnValue: _FakeISentrySpan_2()) as _i4.ISentrySpan);
+  @override
+  _i4.ISentrySpan startTransactionWithContext(
+          _i4.SentryTransactionContext? transactionContext,
+          {Map<String, dynamic>? customSamplingContext,
+          bool? bindToScope}) =>
+      (super.noSuchMethod(
+          Invocation.method(#startTransactionWithContext, [
+            transactionContext
+          ], {
+            #customSamplingContext: customSamplingContext,
+            #bindToScope: bindToScope
+          }),
+          returnValue: _FakeISentrySpan_2()) as _i4.ISentrySpan);
+  @override
+  _i5.Future<_i2.SentryId> captureTransaction(
+          _i2.SentryTransaction? transaction) =>
+      (super.noSuchMethod(Invocation.method(#captureTransaction, [transaction]),
+              returnValue: Future<_i2.SentryId>.value(_FakeSentryId_0()))
+          as _i5.Future<_i2.SentryId>);
+  @override
+  void setSpanContext(
+          dynamic throwable, _i4.ISentrySpan? span, String? transaction) =>
+      super.noSuchMethod(
+          Invocation.method(#setSpanContext, [throwable, span, transaction]),
+          returnValueForMissingStub: null);
+  @override
+  String toString() => super.toString();
 }
 
 /// A class which mocks [Transport].
 ///
 /// See the documentation for Mockito's code generation for more information.
-class MockTransport extends _i1.Mock implements _i9.Transport {
+class MockTransport extends _i1.Mock implements _i8.Transport {
   MockTransport() {
     _i1.throwOnMissingStub(this);
   }
 
   @override
-  _i4.Future<_i2.SentryId> send(_i10.SentryEnvelope? envelope) =>
+  _i5.Future<_i2.SentryId?> send(_i9.SentryEnvelope? envelope) =>
       (super.noSuchMethod(Invocation.method(#send, [envelope]),
-              returnValue: Future<_i2.SentryId>.value(_FakeSentryId()))
-          as _i4.Future<_i2.SentryId>);
+              returnValue: Future<_i2.SentryId?>.value())
+          as _i5.Future<_i2.SentryId?>);
+  @override
+  String toString() => super.toString();
 }

flutter/test/sentry_navigator_observer_test.dart

@@ -1,3 +1,4 @@
+import 'package:flutter/material.dart';
 import 'package:flutter/widgets.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:mockito/mockito.dart';
@@ -6,13 +7,37 @@ import 'package:sentry_flutter/sentry_flutter.dart';
 import 'mocks.dart';
 import 'mocks.mocks.dart';
 
+
 void main() {
   late Fixture fixture;
 
+  PageRoute route(RouteSettings? settings) => PageRouteBuilder<void>(
+    pageBuilder: (_, __, ___) => Container(),
+    settings: settings,
+  );
+
   setUp(() {
     fixture = Fixture();
   });
 
+  group('RouteObserverTransaction', () {
+    test('didPush starts transaction', () {
+      final currentRoute = route(RouteSettings(name: 'Current Route'));
+
+      final hub = MockHub();
+      when(hub.startTransaction('Current Route', 'ui.load', description: null, bindToScope: true, customSamplingContext: null)).thenReturn(NoOpSentrySpan());
+      final sut = fixture.getSut(hub: hub, setRouteNameAsTransaction: false);
+
+      sut.didPush(currentRoute, null);
+
+      verify(hub.startTransaction('Current Route', 'ui.load', description: null, bindToScope: true, customSamplingContext: null));
+    });
+
+    test('didPush finishes previous transaction', () {
+
+    });
+  });
+
   group('RouteObserverBreadcrumb', () {
     test('happy path with string route agrument', () {
       const fromRouteSettings = RouteSettings(
@@ -142,10 +167,7 @@ void main() {
   });
 
   group('SentryNavigatorObserver', () {
-    PageRoute route(RouteSettings? settings) => PageRouteBuilder<void>(
-          pageBuilder: (_, __, ___) => Container(),
-          settings: settings,
-        );
+
 
     RouteSettings routeSettings(String? name, [Object? arguments]) =>
         RouteSettings(name: name, arguments: arguments);