Fix linters and ignore web tests for vm only tests #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
May 12, 2022
marandaneto
commented
May 12, 2022
| enum DataCategory { | ||
| all, | ||
| data_category_default, // default | ||
| dataCategoryDefault, // default |
Contributor
Author
There was a problem hiding this comment.
@denrase I hope this is fine, since camelCase is recommended by the new linter.
Codecov Report
@@ Coverage Diff @@
## main #861 +/- ##
==========================================
+ Coverage 90.33% 92.43% +2.10%
==========================================
Files 119 26 -93
Lines 3785 806 -2979
==========================================
- Hits 3419 745 -2674
+ Misses 366 61 -305 Continue to review full report at Codecov.
|
Contributor
Author
|
|
marandaneto
commented
May 12, 2022
| - name: Test chrome | ||
| if: runner.os != 'macOS' | ||
| if: runner.os == 'Linux' |
Contributor
Author
There was a problem hiding this comment.
#500
Right now it only happens on Windows, let's see if that helps.
ueman
reviewed
May 12, 2022
marandaneto
commented
May 13, 2022
marandaneto
changed the title
Contributor
Author
They fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
#skip-changelog
Dart 2.17 and Flutter 3.0 have new linters that needed to be fixed.
Added the new linter libs instead of the old ones.
Vm only tests are not run on web anymore.
Excluded windows from running web tests, since it was flaky.
💡 Motivation and Context
Closes #507
Closes #860
💚 How did you test it?
📝 Checklist
🔮 Next steps