Skip to content

Fix SentryAssetBundle on Flutter > 3.1 #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 6 commits into from
Jun 7, 2022
Merged

Fix SentryAssetBundle on Flutter > 3.1 #877

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
feb14ab
Fix asset bundle
ueman Jun 6, 2022
9cfe82d
changelog
ueman Jun 6, 2022
7c33cae
Update CHANGELOG.md
ueman Jun 6, 2022
d194c3b
Update flutter/lib/src/sentry_asset_bundle.dart
ueman Jun 6, 2022
0a9c4aa
Update flutter/lib/src/sentry_asset_bundle.dart
ueman Jun 6, 2022
441b19c
Update flutter/test/sentry_asset_bundle_test.dart
ueman Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update flutter/lib/src/sentry_asset_bundle.dart
  • Loading branch information
@ueman
ueman authored Jun 6, 2022
commit d194c3b1e1e6aad17e3a0bf41022fa16d286a888
2 changes: 1 addition & 1 deletion flutter/lib/src/sentry_asset_bundle.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class SentryAssetBundle implements AssetBundle {
}

@override
// This is an override on Flutter 3.1 (I guess) and later
// This is an override on Flutter greater than 3.1
// ignore: override_on_non_overriding_member
Future<ImmutableBuffer> loadBuffer(String key) async {
final span = _hub.getSpan()?.startChild(
Expand Down