Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 7, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

enha: add gh action changelog verifier

💡 Motivation and Context

so we don't forget to change the changelog

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto
Copy link
Contributor Author

changelog / validate-changelog (pull_request) fails because changelog has been moved to the root folder :)

@marandaneto marandaneto requested review from a team and rxlabz October 7, 2020 12:56
Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit bd16410 into main Oct 7, 2020
@marandaneto marandaneto deleted the enha/changelog-verifier branch October 7, 2020 13:23
- move the `package:pedantic` to dev depencies #94
- Added GH Action Changelog verifier #95

# `package:sentry` changelog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem out of place now. Since all changes are related to package:sentry but are above this section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants