Merged
Conversation
lucas-zimerman
commented
Jul 2, 2021
samples/Sentry.Samples.Console.Basic/Sentry.Samples.Console.Basic.csproj
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
- Coverage 80.72% 80.71% -0.01%
==========================================
Files 194 194
Lines 6359 6363 +4
Branches 1411 1411
==========================================
+ Hits 5133 5136 +3
Misses 764 764
- Partials 462 463 +1
Continue to review full report at Codecov.
|
lucas-zimerman
commented
Jul 2, 2021
lucas-zimerman
commented
Jul 2, 2021
revised code
Tyrrrz
reviewed
Jul 2, 2021
lucas-zimerman
commented
Jul 3, 2021
Simplified while loop
bruno-garcia
reviewed
Jul 5, 2021
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
bruno-garcia
reviewed
Jul 7, 2021
bruno-garcia
reviewed
Jul 7, 2021
test/Sentry.Tests/ScopeTests.cs
Outdated
Comment on lines
+236
to
+237
| _ = scope.Attachments.Should().Contain(attachment, "Attachment was not found."); | ||
| _ = scope.Attachments.Should().Contain(attachment2, "Attachment2 was not found."); |
Member
There was a problem hiding this comment.
Suggested change
| _ = scope.Attachments.Should().Contain(attachment, "Attachment was not found."); | |
| _ = scope.Attachments.Should().Contain(attachment2, "Attachment2 was not found."); | |
| scope.Attachments.Should().Contain(attachment, "Attachment was not found."); | |
| scope.Attachments.Should().Contain(attachment2, "Attachment2 was not found."); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the user to clear the attachments.
partially closes #1088 (PR for docs is required)