Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
+ Coverage 82.60% 82.61% +0.01%
==========================================
Files 212 215 +3
Lines 7116 7150 +34
Branches 1401 1407 +6
==========================================
+ Hits 5878 5907 +29
- Misses 804 808 +4
- Partials 434 435 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bruno-garcia This integration will work on .NET Standard 2.1. |
|
We need to make this work with 4.6.1 so if we need to bump the min EF version then lets do that 6.2.0 is from 2017 so definitely not a problem: https://www.nuget.org/packages/EntityFramework/6.2.0 |
That's great cus that's what I did :D (Increased EF version to 6.2.0 on NET461) |
src/Sentry.EntityFramework/Internals/Extensions/DbCommandInterceptionContextExtensions.cs
Outdated
Show resolved
Hide resolved
Fix requested changes.
Fix requested changes and fix test. Updated verify check.
This PR allows the SDK to automatically create Spans for operations related to Entity Framework.
For keeping the pattern with DiagnosticSource, I have edited some names for better understanding:
ReaderExecuting will result on a span with operation "db.query"
ScalarExecutingwill result on a span with operation "db.query-scalar"
NonQueryExecutingwill result on a span with operation "db.execute"
Samples:
https://sentry.io/organizations/sentry-sdks/discover/sentry-dotnet:a6e624483558476bbf4e3a8ec3c1f477/?field=title&field=event.type&field=project&field=user.display&field=timestamp&name=All+Events&query=&sort=-timestamp&statsPeriod=1h&user=314270&yAxis=count%28%29
https://sentry.io/organizations/sentry-sdks/discover/sentry-dotnet:a7faaa0dde1c43fa95948bda62d3606f/?field=title&field=event.type&field=project&field=user.display&field=timestamp&name=All+Events&query=&sort=-timestamp&statsPeriod=1h&user=314270&yAxis=count%28%29
https://sentry.io/organizations/sentry-sdks/discover/sentry-dotnet:72a5884526174201aa0575a01bb780a1/?field=title&field=event.type&field=project&field=user.display&field=timestamp&name=All+Events&query=&sort=-timestamp&statsPeriod=1h&user=314270&yAxis=count%28%29
Close #1173.