Skip to content

feat: EF 6 Query as Span.#1107

Merged
SimonCropp merged 33 commits intomainfrom
feat/ef-query
Nov 9, 2021
Merged

feat: EF 6 Query as Span.#1107
SimonCropp merged 33 commits intomainfrom
feat/ef-query

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Jul 6, 2021

@lucas-zimerman lucas-zimerman added the Feature New feature or request label Jul 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

❌ Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.61%. Comparing base (b624635) to head (b47c7ee).
⚠️ Report is 1971 commits behind head on main.

Files with missing lines Patch % Lines
....EntityFramework/SentryQueryPerformanceListener.cs 76.19% 3 Missing and 2 partials ⚠️
.../Sentry.EntityFramework/SentryOptionsExtensions.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
+ Coverage   82.60%   82.61%   +0.01%     
==========================================
  Files         212      215       +3     
  Lines        7116     7150      +34     
  Branches     1401     1407       +6     
==========================================
+ Hits         5878     5907      +29     
- Misses        804      808       +4     
- Partials      434      435       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lucas-zimerman lucas-zimerman changed the title feat: EF/EF Core Query as Span. feat: EF Query as Span. Jul 8, 2021
@bruno-garcia bruno-garcia changed the title feat: EF Query as Span. feat: EF 6 Query as Span. Aug 4, 2021
@lucas-zimerman
Copy link
Collaborator Author

@bruno-garcia This integration will work on .NET Standard 2.1.
On, NET461 there isn't much to be done with the current version of EntityFramework. BUT, we could update it on NET461 from 6.0.0 to 6.2.0 and it should work.

@lucas-zimerman lucas-zimerman marked this pull request as ready for review September 8, 2021 17:21
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b47c7ee

@bruno-garcia
Copy link
Member

BUT, we could update it on NET461 from 6.0.0 to 6.2.0 and it should work.

We need to make this work with 4.6.1 so if we need to bump the min EF version then lets do that

6.2.0 is from 2017 so definitely not a problem: https://www.nuget.org/packages/EntityFramework/6.2.0

@lucas-zimerman
Copy link
Collaborator Author

BUT, we could update it on NET461 from 6.0.0 to 6.2.0 and it should work.

We need to make this work with 4.6.1 so if we need to bump the min EF version then lets do that

6.2.0 is from 2017 so definitely not a problem: https://www.nuget.org/packages/EntityFramework/6.2.0

That's great cus that's what I did :D (Increased EF version to 6.2.0 on NET461)

Fix requested changes.
Fix requested changes and fix test.
Updated verify check.
@SimonCropp SimonCropp merged commit 15064c5 into main Nov 9, 2021
@SimonCropp SimonCropp deleted the feat/ef-query branch November 9, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EF 6 Spans for queries

6 participants