Skip to content

fix installation id catches dir not exist #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bruno-garcia merged 2 commits into from
Aug 17, 2021
Merged

fix installation id catches dir not exist #1159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5679b11
fix installation id catches dir not exist
bruno-garcia Aug 17, 2021
21b5add
changelog
bruno-garcia Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@

### Fixes

### Features

### Fixes

- Installation id catches dir not exist([#1159](https://github.com/getsentry/sentry-dotnet/pull/1159))
Copy link
Collaborator

@lucas-zimerman lucas-zimerman Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Installation id catches dir not exist (#1159)

We need to fix the missing space from Dange :)

- Set error status to transaction if http has exception and ok status ([#1143](https://github.com/getsentry/sentry-dotnet/pull/1143))
- Fix max breadcrumbs limit when MaxBreadcrumbs is zero or lower ([#1145](https://github.com/getsentry/sentry-dotnet/pull/1145))

Expand Down
8 changes: 8 additions & 0 deletions src/Sentry/GlobalSessionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,14 @@ public GlobalSessionManager(
filePath
);
}
catch (DirectoryNotFoundException)
{
// on PS4 we're seeing CreateDirectory work but ReadAllText throw DirectoryNotFoundException
_options.DiagnosticLogger?.LogDebug(
"Directory containing installation ID does not exist ({0}).",
filePath
);
}

// Generate new installation ID and store it in a file
var id = Guid.NewGuid().ToString();
Expand Down