Skip to content

Fix: GCP flush before error thrown.#1249

Merged
lucas-zimerman merged 2 commits intomainfrom
fix/gcp-flush
Oct 11, 2021
Merged

Fix: GCP flush before error thrown.#1249
lucas-zimerman merged 2 commits intomainfrom
fix/gcp-flush

Conversation

@lucas-zimerman
Copy link
Collaborator

This adds a new flush method called FlushBeforeRequestCompleted, instead of flushing after the request is sent like in FlushOnCompletedRequest, this flag sends the envelopes before sending the response to the user.

It's a required flow for some serverless/Faas platforms that will kill the process after flushing the HttpResponse to the receiver.

I made it internal for now and ideally in the future we could have a simple enum that will set the flush type (none, on completed, before completed).

Close #1213

@lucas-zimerman lucas-zimerman added the Bug Something isn't working label Oct 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.76%. Comparing base (6f14500) to head (e32e05e).
⚠️ Report is 2146 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
+ Coverage   80.61%   80.76%   +0.14%     
==========================================
  Files         212      212              
  Lines        6913     6920       +7     
  Branches     1591     1596       +5     
==========================================
+ Hits         5573     5589      +16     
+ Misses        809      803       -6     
+ Partials      531      528       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lucas-zimerman lucas-zimerman merged commit abd6dc3 into main Oct 11, 2021
@lucas-zimerman lucas-zimerman deleted the fix/gcp-flush branch October 11, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Cloud Functions: Envelopes are not being sent to Sentry

3 participants