Skip to content

Add missing ConfigureAwaits(false) for async using#1276

Merged
SimonCropp merged 12 commits intomainfrom
missingConfigureAwait
Oct 18, 2021
Merged

Add missing ConfigureAwaits(false) for async using#1276
SimonCropp merged 12 commits intomainfrom
missingConfigureAwait

Conversation

@SimonCropp
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #1276 (65899cd) into main (7b2e60f) will increase coverage by 1.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   80.12%   81.62%   +1.49%     
==========================================
  Files         212      212              
  Lines        7029     7047      +18     
  Branches     1465     1466       +1     
==========================================
+ Hits         5632     5752     +120     
+ Misses        955      847     -108     
- Partials      442      448       +6     
Impacted Files Coverage Δ
src/Sentry/Envelopes/Envelope.cs 97.67% <100.00%> (+1.28%) ⬆️
src/Sentry/Envelopes/EnvelopeItem.cs 91.53% <100.00%> (+1.06%) ⬆️
src/Sentry/Envelopes/JsonSerializable.cs 100.00% <100.00%> (+16.66%) ⬆️
...Sentry/Internal/Extensions/HttpClientExtensions.cs 100.00% <100.00%> (ø)
src/Sentry/Internal/Http/CachingTransport.cs 84.82% <100.00%> (+0.54%) ⬆️
...ry/Internal/Http/GzipBufferedRequestBodyHandler.cs 92.00% <100.00%> (+0.69%) ⬆️
src/Sentry/Internal/Http/HttpTransport.cs 94.89% <100.00%> (+0.03%) ⬆️
src/Sentry/Internal/SerializableExtensions.cs 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2e60f...65899cd. Read the comment docs.

@SimonCropp SimonCropp changed the title Add missing configure awaits Add missing ConfigureAwaits(false) for async using Oct 18, 2021
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! thank you

SimonCropp and others added 2 commits October 18, 2021 23:20
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@SimonCropp SimonCropp merged commit 317d4ad into main Oct 18, 2021
@SimonCropp SimonCropp deleted the missingConfigureAwait branch October 18, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants