Rename thread pool protocol keys to snake case#1472
Merged
bruno-garcia merged 4 commits intomainfrom Feb 11, 2022
Merged
Conversation
Contributor
Author
|
@bruno-garcia so should these be snake case as well? |
Member
|
Either the way we want to show in the UI if not part of the protocol, or snake case and added to develop docs and changes in sentry UI to render nicely. The "UI" culture is a known protocol I believe, just the key there is different because we add two instances. |
bruno-garcia
approved these changes
Feb 8, 2022
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
Should we have some snapshot or other type of tests to validate this?
Codecov Report
@@ Coverage Diff @@
## main #1472 +/- ##
==========================================
+ Coverage 84.25% 84.26% +0.01%
==========================================
Files 219 219
Lines 7387 7387
Branches 1417 1417
==========================================
+ Hits 6224 6225 +1
Misses 727 727
+ Partials 436 435 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1471