Conversation
Needs tests
CI is much slower than expected, so can't rely on timing part of the test. The test still proves that the expected values are achieved.
Parallel.ForEach is a better choice than async/await for this
bruno-garcia
left a comment
There was a problem hiding this comment.
This is looking great. One concern about value tuples on netfx
|
Note, I'll need to refactor this to use the transport afterall. Doing it in the background worker will get in the way of the changes I'm getting ready to submit to support extensibility (for Unity WebGL). I have a plan... |
philipphofmann
left a comment
There was a problem hiding this comment.
Looking better every day 👍
Codecov Report
@@ Coverage Diff @@
## main #1556 +/- ##
==========================================
- Coverage 84.34% 84.21% -0.14%
==========================================
Files 219 224 +5
Lines 7423 7520 +97
Branches 1417 1427 +10
==========================================
+ Hits 6261 6333 +72
- Misses 735 759 +24
- Partials 427 428 +1
Continue to review full report at Codecov.
|
Implement Client Reports. Resolves #1455
Ready for review!