Skip to content

Re-implement InitCacheFlushTimeout option and tests#1644

Merged
mattjohnsonpint merged 11 commits intomainfrom
fix-blockcacheflush
May 6, 2022
Merged

Re-implement InitCacheFlushTimeout option and tests#1644
mattjohnsonpint merged 11 commits intomainfrom
fix-blockcacheflush

Conversation

@mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented May 6, 2022

Fixes #1642, #1640 and #803

@mattjohnsonpint mattjohnsonpint marked this pull request as draft May 6, 2022 01:29
@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review May 6, 2022 18:28
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler solution, thanks Matt!

mattjohnsonpint and others added 4 commits May 6, 2022 11:41
Will prevent threading issues with counting while adding
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- Re-implement InitCacheFlushTimeout option and tests ([#1644](https://github.com/getsentry/sentry-dotnet/pull/1644))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 911d8e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove BlockCacheFlush and improve InitCacheFlushTimeout mechanism

2 participants