Support Dynamic Sampling#1953

Merged

mattjohnsonpint merged 30 commits intomainfrom

dynamic-sampling

Oct 4, 2022

Contributor

mattjohnsonpint commented Sep 28, 2022 •

edited

Loading

Adding .NET SDK support for dynamic sampling, per #1840

Includes:

DynamicSamplingContext
BaggageHeader
TracePropagationTarget
Outbound headers sent with SentryHttpMessageHandler
Inbound headers respected in ASP.NET and ASP.NET Core tracing integrations
Lots of tests

mattjohnsonpint added 14 commits

September 27, 2022 09:00


          Update existing text unrelated to dynamic sampling

8db993e


          Add baggage header and DSC

ab7ad3d


          Update tracing middleware for ASP.NET Core

c42d148


          Update tests

532b720


          Update verify tests for Windows build

3a7595b


          mark verify tests

9ad0fe1


          Update CHANGELOG.md


          Apply baggage headers

5bd3504


          Simplify baggage header

39fc013


          More baggage header tests

382da98


          More baggage and DSC

3b84f03


          Don't make DSC public

7d2594d


          Refactor

fa363f8


          DSC tests

5c9300c

mattjohnsonpint changed the title ~~WIP: Dynamic sampling~~ Support Dynamic Sampling

mattjohnsonpint added 3 commits

September 29, 2022 11:12


          Add ASP.NET support

9b42274


          Add baggage propagation test

0f457b2


          DSC end-to-end test

SimonCropp reviewed

View reviewed changes

src/Sentry/BaggageHeader.cs Outdated Show resolved Hide resolved

SimonCropp reviewed

View reviewed changes

src/Sentry/BaggageHeader.cs Outdated Show resolved Hide resolved

SimonCropp reviewed

View reviewed changes

src/Sentry/BaggageHeader.cs Show resolved Hide resolved

SimonCropp reviewed

View reviewed changes

src/Sentry/DynamicSamplingContext.cs Show resolved Hide resolved

SimonCropp reviewed

View reviewed changes

src/Sentry/HubExtensions.cs Show resolved Hide resolved

SimonCropp reviewed

View reviewed changes

src/Sentry/BaggageHeader.cs Show resolved Hide resolved

SimonCropp reviewed

View reviewed changes

test/Sentry.Tests/BaggageHeaderTests.cs Show resolved Hide resolved

SimonCropp reviewed

View reviewed changes

test/Sentry.AspNetCore.Tests/SentryTracingMiddlewareTests.cs Outdated Show resolved Hide resolved

Contributor

SimonCropp commented Sep 30, 2022

would any of this be useful https://github.com/VerifyTests/Verify.Http ?

mattjohnsonpint added 3 commits

September 30, 2022 17:38


          Merge branch 'main' into dynamic-sampling

09c86fb


          Add some logging

abe26e5


          misc

34ddb3c

mattjohnsonpint added 9 commits

October 3, 2022 16:41


          Get logger once in static initialization

34f997d


          Add extension method for getting options

cec6271


          Add TracePropogationTargets

60287d4


          Update API verifications

3a7e919


          Refactor and add tests

9bf673b


          Add tests


          Add tests

77812f4


          Support setting option via json config file

c7e92ad


          Update API verifications

3409cdf

Contributor Author

mattjohnsonpint commented Oct 4, 2022

would any of this be useful https://github.com/VerifyTests/Verify.Http ?

In general, yes. But not at this time. Thanks.

mattjohnsonpint marked this pull request as ready for review

October 4, 2022 01:35

mattjohnsonpint requested a review from bruno-garcia

October 4, 2022 01:40

mattjohnsonpint commented

View reviewed changes

test/Sentry.AspNetCore.Tests/allsettings.json Outdated Show resolved Hide resolved

marandaneto reviewed

View reviewed changes

src/Sentry.AspNet/HttpContextExtensions.cs Show resolved Hide resolved

marandaneto reviewed

View reviewed changes

src/Sentry.AspNetCore/SentryTracingMiddleware.cs Show resolved Hide resolved

marandaneto reviewed

View reviewed changes

src/Sentry/BaggageHeader.cs Show resolved Hide resolved

marandaneto reviewed

View reviewed changes

src/Sentry/Protocol/Envelopes/Envelope.cs Show resolved Hide resolved

marandaneto reviewed

View reviewed changes

src/Sentry/SentryOptions.cs Outdated Show resolved Hide resolved


          Update TracePropagationTargets implementation

6474ccc

SimonCropp approved these changes

View reviewed changes

mattjohnsonpint merged commit 0d85ef6 into main

mattjohnsonpint deleted the dynamic-sampling branch

October 4, 2022 22:16

mattjohnsonpint mentioned this pull request

Add .NET to supported SDKs for DS getsentry/sentry#39783

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet