Add Scope.Clear and Scope.ClearBreadcrumbs methods#2284
Merged
mattjohnsonpint merged 4 commits intogetsentry:mainfrom Apr 6, 2023
Merged
Add Scope.Clear and Scope.ClearBreadcrumbs methods#2284mattjohnsonpint merged 4 commits intogetsentry:mainfrom
mattjohnsonpint merged 4 commits intogetsentry:mainfrom
Conversation
See getsentry#2272 for full context.
jamescrosswell
requested review from
bitsandfoxes and
mattjohnsonpint
as code owners
jamescrosswell
commented
Apr 3, 2023
Contributor
|
Thanks for the PR! I'll review soon and get back to you. 🙂 |
mattjohnsonpint
suggested changes
Apr 4, 2023
Contributor
mattjohnsonpint
left a comment
mattjohnsonpint
left a comment
There was a problem hiding this comment.
Looks pretty good overall! A few things to address as indicated inline.
Also:
- After you switch the methods public, re-run tests locally and you'll see the public API snapshots have been updated. Commit those. (You can use
dotnet test test/Sentry.Tests --filter ApiApprovalTestsif you want to do it fast. Or just run all tests.) - Add an entry to
CHANGELOG.md, pointing back at this PR.
Thanks!
- Provided summary documentation for the ClearBreadcrumbs method - Committed updated verified.txt files for API approval tests
…e SentryScopeManager - Added extension method to set fake values on a Scope during testing - Added extension method to ensure Scopes are equivalent during testing
mattjohnsonpint
approved these changes
Apr 6, 2023
Contributor
|
Nice job. Thanks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2272