Improvements to exception mechanism data#2294
Merged
mattjohnsonpint merged 8 commits intomainfrom Apr 11, 2023
Merged
Conversation
Contributor
Author
Contributor
Author
SeanFeldman
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR address several items related to the
exception.mechanismdata sent to Sentry.Prevents an empty mechanism. Either
exception.mechanismis omitted, or theexception.mechanism.typefield will be set. Defaults the mechanism type to"generic"when not set by another method.Fixes Exception mechanism type unset #2288.
Moves extra data added to
System.Exception.Datato theexception.mechanism.datacollection, instead of placing it inexception.extra. This places it near the exception in the issue details page, and renders it correctly.Fixes Move exception data to mechanism #2289.
Adds descriptions to exception mechanisms for built-in integrations, and a new
SetSentryMechanismextension method for convenience. Also adds a property for thesyntheticfield. Omits it unless true. The default is false.Fixes Unused mechanism fields #2290.
Sets
exception.mechanism.handledtotruein the case of an exception that was thrown, caught, and manually captured. As an example:Fixes Add
handled:truewhen an exception has been handled #1480.