Fix EnableTracing option conflict with TracesSampleRate#2368
Merged
mattjohnsonpint merged 5 commits intomainfrom May 14, 2023
Merged
Fix EnableTracing option conflict with TracesSampleRate#2368mattjohnsonpint merged 5 commits intomainfrom
EnableTracing option conflict with TracesSampleRate#2368mattjohnsonpint merged 5 commits intomainfrom
Conversation
SeanFeldman
approved these changes
May 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2366 by having
TracesSampleRateandEnableTracingproperties have simple get/set implementations (except for some existing validation). This issue was mainly seen during configuration binding in ASP.NET Core applications, and then - only in the case whereEnableTracingwas settrueandTracesSampleRatewas unset.Unfortunately, the only way to implement the correct fix was to make
TracesSampleRatea nullabledouble?. Previously, it was a non-nullabledouble. (The default value is nownullinstead of0.0.) Normally I'd consider that to be a breaking change that could not be done without a major version bump. But in this case, it's unlikely to affect anyone, because this property is typical set, but never retrieved externally.There are no behavioral changes. Both values work as they were originally intended.
I also improved the xmldocs, and fixed the exception type thrown when an invalid sample rate is set. (
ArgumentOutOfRangeException, is more appropriate thanInvalidOperationExceptionfor that).