Remove TracePropagationTarget

[jamescrosswell]

Resolves #2666

Motivation

TracePropagationTarget currently doesn't add any functionality over/above SubstringOrRegexPattern, so there's no need to retain both of these:

[TypeConverter(typeof(TracePropagationTargetTypeConverter))]
public class TracePropagationTarget: SubstringOrRegexPattern
{
    public TracePropagationTarget(string substringOrRegexPattern, StringComparison comparison = StringComparison.OrdinalIgnoreCase)
        : base(substringOrRegexPattern, comparison)
    {
    }

    public TracePropagationTarget(Regex regex) : base (regex)
    {
    }
}

SubstringOrRegexPattern is the less specific type that is also used for FailedRequestTargets:

sentry-dotnet/src/Sentry/SentryOptions.cs

Lines 678 to 680 in f2524bd

	// The default failed request target list will match anything, but adding to the list should clear that.
	private IList<SubstringOrRegexPattern> _failedRequestTargets = new AutoClearingList<SubstringOrRegexPattern>(
	new[] { new SubstringOrRegexPattern(".*") }, clearOnNextAdd: true);

[bruno-garcia]

It doesn't really explain why.
This type at least from what its named is part of Sentry's protocol and easy to find in docs, etc.

It's getting removed just because it's 'the same as SubstringOrRegexPattern'?

[jamescrosswell]

I put some context in the PR description. I think the TracePropagationTargets property will still be easy enough to find and is well documented and having it's own type wouldn't make it any more usable:

sentry-dotnet/src/Sentry/SentryOptions.cs

Lines 824 to 842 in f2524bd

	/// <summary>
	/// A customizable list of <see cref="SubstringOrRegexPattern"/> objects, each containing either a
	/// substring or regular expression pattern that can be used to control which outgoing HTTP requests
	/// will have the <c>sentry-trace</c> and <c>baggage</c> headers propagated, for purposes of distributed tracing.
	/// The default value contains a single value of <c>.*</c>, which matches everything.
	/// To disable propagation completely, clear this collection or set it to an empty collection.
	/// </summary>
	/// <seealso href="https://develop.sentry.dev/sdk/performance/#tracepropagationtargets"/>
	/// <remarks>
	/// Adding an item to the default list will clear the <c>.*</c> value automatically.
	/// </remarks>
	public IList<SubstringOrRegexPattern> TracePropagationTargets
	{
	// NOTE: During configuration binding, .NET 6 and lower used to just call Add on the existing item.
	// .NET 7 changed this to call the setter with an array that already starts with the old value.
	// We have to handle both cases.
	get => _tracePropagationTargets;
	set => _tracePropagationTargets = value.SetWithConfigBinding();
	}

[bitsandfoxes]

Thanks!