Skip to content

Removed IUserFactory in favor of ISentryUserFactory#2840

Merged
vaind merged 7 commits intofeat/4.0.0from
fix/remove-iuserfactory
Nov 17, 2023
Merged

Removed IUserFactory in favor of ISentryUserFactory#2840
vaind merged 7 commits intofeat/4.0.0from
fix/remove-iuserfactory

Conversation

@bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Nov 15, 2023

If I got that right:
Sentry's ServiceCollectionExtension adds the HttpContextAccessor.

That way the DefaultUserFactory is able to access the context and no longer requires it to be passed down.

Also resolves #2844

@jamescrosswell
Copy link
Collaborator

That way the DefaultUserFactory is able to access the context and no longer requires it to be passed down.

Exactly, yeah.

Might be worth checking if this is related, while we're making changes here:

@bitsandfoxes
Copy link
Contributor Author

Might be worth checking if this is related, while we're making changes here:

Yes. It coincidentally fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants