Removed IUserFactory in favor of ISentryUserFactory#2840
Merged
vaind merged 7 commits intofeat/4.0.0from Nov 17, 2023
Merged
Conversation
Collaborator
Exactly, yeah. Might be worth checking if this is related, while we're making changes here: |
Contributor
Author
Yes. It coincidentally fixes this issue. |
vaind
approved these changes
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I got that right:
Sentry's
ServiceCollectionExtensionadds theHttpContextAccessor.sentry-dotnet/src/Sentry.AspNetCore/Extensions/DependencyInjection/ServiceCollectionExtensions.cs
Line 25 in ad6968c
That way the
DefaultUserFactoryis able to access the context and no longer requires it to be passed down.Also resolves #2844