fix: MAUI eventbinding moved to FinishedLaunching#3057
Merged
bitsandfoxes merged 4 commits intomainfrom Jan 18, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3057 +/- ##
==========================================
+ Coverage 75.26% 76.43% +1.17%
==========================================
Files 351 351
Lines 13257 13262 +5
Branches 2645 2646 +1
==========================================
+ Hits 9978 10137 +159
+ Misses 2603 2447 -156
- Partials 676 678 +2 ☔ View full report in Codecov by Sentry. |
bruno-garcia
approved these changes
Jan 17, 2024
jamescrosswell
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2898
So there is nothing really "fixed" here. Putting it in
bitwardenjust highlighted a potential issue with the SDK.There the
apprelies on theFinishedLaunchingcallback to setup their own service container before instantiating theapp. The SDK's call intoservicescauses the app to be instantiated first.Considering that other applications might be doing the same I think it's fair to move the binding to the
FinishedLaunchingas well.