Skip to content

Session Replay: Recording on Android #3552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 8 commits into from
Nov 4, 2024
Merged

Session Replay: Recording on Android #3552

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
165e443
record on android
bruno-garcia Aug 23, 2024
a989495
Merge branch 'main' into hackweek/replay-android
jamescrosswell Oct 28, 2024
56d56d3
Update native options to be consistent with latest java SDK
jamescrosswell Nov 4, 2024
8fb353a
Conditionally reference android specific options in sample
jamescrosswell Nov 4, 2024
6b82707
Update BindableNativeOptionsTests.cs
jamescrosswell Nov 4, 2024
cfd86c7
Merge branch 'main' into hackweek/replay-android
jamescrosswell Nov 4, 2024
6a46186
Update CHANGELOG.md
jamescrosswell Nov 4, 2024
de4ba5b
Merge branch 'main' into hackweek/replay-android
jamescrosswell Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update native options to be consistent with latest java SDK
  • Loading branch information
@jamescrosswell
jamescrosswell committed Nov 4, 2024
commit 56d56d3376c44b3453cf4388a0e6e56ac3299c63
4 changes: 2 additions & 2 deletions src/Sentry/Platforms/Android/BindableNativeSentryOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ public void ApplyTo(SentryOptions.NativeOptions options)
options.ExperimentalOptions.SessionReplay.SessionSampleRate = sessionSampleRate;
#pragma warning restore CA1422
}
ExperimentalOptions.SessionReplay.RedactAllText = options.ExperimentalOptions.SessionReplay.RedactAllText;
ExperimentalOptions.SessionReplay.RedactAllImages = options.ExperimentalOptions.SessionReplay.RedactAllImages;
ExperimentalOptions.SessionReplay.RedactAllText = options.ExperimentalOptions.SessionReplay.MaskAllText;
ExperimentalOptions.SessionReplay.RedactAllImages = options.ExperimentalOptions.SessionReplay.MaskAllImages;
}
}
}
4 changes: 2 additions & 2 deletions src/Sentry/Platforms/Android/NativeOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@ public class NativeSentryReplayOptions
{
public double? OnErrorSampleRate { get; set; }
public double? SessionSampleRate { get; set; }
public bool RedactAllImages { get; set; } = true;
public bool RedactAllText { get; set; } = true;
public bool MaskAllImages { get; set; } = true;
public bool MaskAllText { get; set; } = true;
}
/// <summary>
/// ExperimentalOptions
Expand Down
6 changes: 3 additions & 3 deletions src/Sentry/Platforms/Android/SentrySdk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,12 +163,12 @@ private static void InitSentryAndroidSdk(SentryOptions options)
options.Native.InAppExcludes?.ForEach(o.AddInAppExclude);
options.Native.InAppIncludes?.ForEach(o.AddInAppInclude);

o.Experimental.SessionReplay.ErrorSampleRate =
o.Experimental.SessionReplay.OnErrorSampleRate =
(JavaDouble?)options.Native.ExperimentalOptions.SessionReplay.OnErrorSampleRate;
o.Experimental.SessionReplay.SessionSampleRate =
(JavaDouble?)options.Native.ExperimentalOptions.SessionReplay.SessionSampleRate;
o.Experimental.SessionReplay.RedactAllImages = options.Native.ExperimentalOptions.SessionReplay.RedactAllImages;
o.Experimental.SessionReplay.RedactAllText = options.Native.ExperimentalOptions.SessionReplay.RedactAllText;
o.Experimental.SessionReplay.SetMaskAllImages(options.Native.ExperimentalOptions.SessionReplay.MaskAllImages);
o.Experimental.SessionReplay.SetMaskAllText(options.Native.ExperimentalOptions.SessionReplay.MaskAllText);

// These options are intentionally set and not exposed for modification
o.EnableExternalConfiguration = false;
Expand Down