Skip to content

fix: Route file writing through FileSystem #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitsandfoxes merged 19 commits into from
Sep 26, 2024
Merged

fix: Route file writing through FileSystem #3614

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b2f3283
make use of 'filesystem'
bitsandfoxes Sep 18, 2024
ab7c7e8
Apply suggestions from code review
bitsandfoxes Sep 19, 2024
eea1450
loggign
bitsandfoxes Sep 19, 2024
3cfce14
use filesystem everywhere
bitsandfoxes Sep 19, 2024
967e006
fix tests to use fakefilesystem
bitsandfoxes Sep 19, 2024
cdde5d5
verify
bitsandfoxes Sep 19, 2024
ba1df68
debug instead of warning
bitsandfoxes Sep 20, 2024
21ac35b
make it work
bitsandfoxes Sep 20, 2024
12c604d
Updated CHANGELOG.md
bitsandfoxes Sep 20, 2024
561903e
comment
bitsandfoxes Sep 20, 2024
9f77eb7
kiss
bitsandfoxes Sep 23, 2024
c3ebbab
restored sample
bitsandfoxes Sep 23, 2024
4da424a
make filesystem smarter
bitsandfoxes Sep 23, 2024
9ae1583
split filesystem
bitsandfoxes Sep 24, 2024
2803559
finished split
bitsandfoxes Sep 25, 2024
88d63f0
Merge branch 'main' into fix/filesystem
bitsandfoxes Sep 25, 2024
aa39e58
Format code
getsentry-bot Sep 25, 2024
5aba1d2
logs
bitsandfoxes Sep 25, 2024
e318e89
Updated CHANGELOG.md
bitsandfoxes Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
debug instead of warning
  • Loading branch information
@bitsandfoxes
bitsandfoxes committed Sep 20, 2024
commit ba1df680923a4372c1782c6ee0afab09de198c31
12 changes: 6 additions & 6 deletions src/Sentry/Internal/FileSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public bool CreateDirectory(string path)
{
if (_options?.DisableFileWrite is false)
{
_options?.LogWarning("Skipping creating directory. Writing to file system has been explicitly disabled.");
_options?.LogDebug("Skipping creating directory. Writing to file system has been explicitly disabled.");
return false;
}

Expand All @@ -37,7 +37,7 @@ public bool DeleteDirectory(string path, bool recursive = false)
{
if (_options?.DisableFileWrite is false)
{
_options?.LogWarning("Skipping deleting directory. Writing to file system has been explicitly disabled.");
_options?.LogDebug("Skipping deleting directory. Writing to file system has been explicitly disabled.");
return false;
}

Expand All @@ -53,7 +53,7 @@ public bool MoveFile(string sourceFileName, string destFileName, bool overwrite
{
if (_options?.DisableFileWrite is false)
{
_options?.LogWarning("Skipping moving file. Writing to file system has been explicitly disabled.");
_options?.LogDebug("Skipping moving file. Writing to file system has been explicitly disabled.");
return false;
}

Expand All @@ -77,7 +77,7 @@ public bool DeleteFile(string path)
{
if (_options?.DisableFileWrite is false)
{
_options?.LogWarning("Skipping deleting file. Writing to file system has been explicitly disabled.");
_options?.LogDebug("Skipping deleting file. Writing to file system has been explicitly disabled.");
return false;
}

Expand All @@ -95,7 +95,7 @@ public Stream CreateFileForWriting(string path)
{
if (_options?.DisableFileWrite is false)
{
_options?.LogWarning("Skipping file for writing. Writing to file system has been explicitly disabled.");
_options?.LogDebug("Skipping file for writing. Writing to file system has been explicitly disabled.");
return Stream.Null;
}

Expand All @@ -106,7 +106,7 @@ public bool WriteAllTextToFile(string path, string contents)
{
if (_options?.DisableFileWrite is false)
{
_options?.LogWarning("Skipping writing all text to file. Writing to file system has been explicitly disabled.");
_options?.LogDebug("Skipping writing all text to file. Writing to file system has been explicitly disabled.");
return false;
}

Expand Down