Skip to content

fix: Simplified IFileSystem #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitsandfoxes merged 5 commits into from
Oct 1, 2024
Merged

fix: Simplified IFileSystem #3641

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
155531a
simplified file system
bitsandfoxes Sep 30, 2024
4e6574e
simplify check
bitsandfoxes Sep 30, 2024
efd64b1
comment
bitsandfoxes Sep 30, 2024
bcab2a3
Updated CHANGELOG.md
bitsandfoxes Oct 1, 2024
a8c774d
review
bitsandfoxes Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
review
  • Loading branch information
@bitsandfoxes
bitsandfoxes committed Oct 1, 2024
commit a8c774d9cbb3c2c19b02ac42ccf4d8b592d03c70
2 changes: 1 addition & 1 deletion src/Sentry/GlobalSessionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ private void DeletePersistedSession()

if (_options.DisableFileWrite)
{
_options.LogInfo("File write has been disabled via the options. Skipping deleting persisted session.");
_options.LogInfo("File write has been disabled via the options. Skipping deletion of persisted session files.");
return;
}

Expand Down
5 changes: 1 addition & 4 deletions src/Sentry/Internal/Http/CachingTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,7 @@ private CachingTransport(ITransport innerTransport, SentryOptions options, bool

// Sanity check: This should never happen in the first place.
// We check for `DisableFileWrite` before creating the CachingTransport.
if (_options.DisableFileWrite)
{
throw new InvalidOperationException("File write has been disabled via the options. Cannot create a Caching Transport.");
}
Debug.Assert(!_options.DisableFileWrite);

_processingDirectoryPath = Path.Combine(_isolatedCacheDirectoryPath, ProcessingFolder);
}
Expand Down