Skip to content

Fixes "Failed to persist session" error on iOS #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 2 commits into from
Oct 7, 2024
Merged

Fixes "Failed to persist session" error on iOS #3655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9111b4
Moved writer inside try block to force disposal before file.Dispose()
jamescrosswell Oct 6, 2024
fa61e15
Update CHANGELOG.md
jamescrosswell Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixes

- Fixed "Failed to persist session" error on iOS ([#3655](https://github.com/getsentry/sentry-dotnet/pull/3655))

### Dependencies

- Bump CLI from v2.36.5 to v2.36.6 ([#3647](https://github.com/getsentry/sentry-dotnet/pull/3647))
Expand Down
3 changes: 1 addition & 2 deletions src/Sentry/GlobalSessionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,9 @@ private void PersistSession(SessionUpdate update, DateTimeOffset? pauseTimestamp
return;
}

using var writer = new Utf8JsonWriter(file);

try
{
using var writer = new Utf8JsonWriter(file);
persistedSessionUpdate.WriteTo(writer, _options.DiagnosticLogger);
writer.Flush();
}
Expand Down