Skip to content

Feat: allow logcat attachment to be previewed in Sentry #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 6 commits into from
Oct 31, 2024
Merged

Feat: allow logcat attachment to be previewed in Sentry #3711

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3106b92
android - Logcat processor | change `mime-type`
bricefriha Oct 29, 2024
bbd108e
Merge branch 'main' into feat/#3703_logcat_preview
bricefriha Oct 29, 2024
defbf1a
Device tests - SentryMauiLogcatsTests | Add logcat tests type
bricefriha Oct 30, 2024
4c5f3bd
Device tests - logcat attachment | [skipablefact] -> [fact]
bricefriha Oct 30, 2024
cb14b65
Update test/Sentry.Maui.Tests/SentryMauiLogcatsTests.cs
bricefriha Oct 30, 2024
978e231
Update test/Sentry.Maui.Tests/SentryMauiLogcatsTests.cs
bricefriha Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
android - Logcat processor | change mime-type
  • Loading branch information
@bricefriha
bricefriha committed Oct 29, 2024
commit 3106b9268c6e66b3d43006d942a2c1c18ef2386c
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Features

- Android - allow logcat attachments to be previewed in Sentry ([#3711](https://github.com/getsentry/sentry-dotnet/pull/3711))

## 4.12.1

### Fixes
Expand Down
2 changes: 1 addition & 1 deletion src/Sentry/Platforms/Android/LogCatAttachmentEventProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public SentryEvent Process(SentryEvent @event, SentryHint hint)
output.Seek(0, SeekOrigin.Begin);
var bytes = output.ToArray();

hint.Attachments.Add(new SentryAttachment(AttachmentType.Default, new ByteAttachmentContent(bytes), "logcat.log", "text/logcat"));
hint.Attachments.Add(new SentryAttachment(AttachmentType.Default, new ByteAttachmentContent(bytes), "logcat.log", "text/plain"));

//hint.AddAttachment($"{filesDir.Path}/{fileName}", AttachmentType.Default, "text/logcat");

Expand Down