Skip to content

Suppress Native SIGSEGV signal errors on Android #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 11 commits into from
Feb 10, 2025
Merged

Suppress Native SIGSEGV signal errors on Android #3903

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
59ef782
Disable the NDK by default
jamescrosswell Jan 17, 2025
179d173
Update CHANGELOG.md
jamescrosswell Jan 17, 2025
60ea6ee
Merge branch 'main' into disable-ndk
jamescrosswell Jan 28, 2025
3485321
Revert EnableNdk to true by default
jamescrosswell Feb 3, 2025
a054087
Suppress SIGSEGV exceptions in the Native BeforeSend callback
jamescrosswell Feb 3, 2025
131522b
Merge branch 'main' into disable-ndk
jamescrosswell Feb 3, 2025
c3c1278
Update CHANGELOG.md
jamescrosswell Feb 3, 2025
19edfc5
Merge branch 'main' into disable-ndk
jamescrosswell Feb 4, 2025
664b37f
Added device tests for the Android BeforeSendWrapper
jamescrosswell Feb 4, 2025
370efa0
Update SentrySdk.cs
jamescrosswell Feb 6, 2025
e06c09c
Added option to enable/disable Segfault suppression
jamescrosswell Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert EnableNdk to true by default
  • Loading branch information
@jamescrosswell
jamescrosswell committed Feb 3, 2025
commit 34853214fb91015f185e447114116c7c0bdc30b8
10 changes: 2 additions & 8 deletions src/Sentry/Platforms/Android/NativeOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,19 +167,13 @@ internal NativeOptions(SentryOptions options)
public TimeSpan ConnectionTimeout { get; set; } = TimeSpan.FromSeconds(5);

/// <summary>
/// <para>
/// Gets or sets a value that indicates if the NDK (Android Native Development Kit) is enabled.
/// The default value is <c>false</c> (disabled).
/// </para>
/// <para>
/// NOTE: We do not currently recommend enabling this feature.
/// See: https://github.com/getsentry/sentry-dotnet/issues/3902
/// </para>
/// The default value is <c>true</c> (enabled).
/// </summary>
/// <remarks>
/// See https://docs.sentry.io/platforms/android/using-ndk/#disable-ndk-integration
/// </remarks>
public bool EnableNdk { get; set; } = false;
public bool EnableNdk { get; set; } = true;

/// <summary>
/// Gets or sets a value that indicates if the hook that flushes when the main Java thread shuts down
Expand Down