Skip to content

fix: net8 unknown stack trace methods for JIT methods #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vaind merged 6 commits into from
Feb 7, 2025
Merged

fix: net8 unknown stack trace methods for JIT methods #3942

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71c61ca
fix: net8 unknown stack trace methods for JIT methods
vaind Feb 6, 2025
ec27490
chore: changelog
vaind Feb 6, 2025
bd58c21
chore: fix changelog
vaind Feb 6, 2025
d865e36
remove problematic assertion
vaind Feb 6, 2025
4efb384
fix: dispose before processing is done
vaind Feb 6, 2025
c809fe4
Merge branch 'main' into fix/profiling-net8-unknow-stack-frames
vaind Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove problematic assertion
  • Loading branch information
@vaind
vaind committed Feb 6, 2025
commit d865e36922ebc986b00164a17e01183bd24ba2c6
1 change: 0 additions & 1 deletion test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,8 @@

Assert.Contains("Method/LoadVerbose", eventsReceived);
Assert.Contains("Method/ILToNativeMap", eventsReceived);
Assert.Contains("Method/UnloadVerbose", eventsReceived);

Assert.Contains("MethodToBeLoaded", loadedMethods);

Check failure on line 209 in test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

Sentry.Profiling.Tests.SamplingTransactionProfilerTests.EventPipeSession_ReceivesExpectedCLREvents 

Assert.Contains() Failure: Item not found in set
Set:       ["RemoveRange", "PickPivotAndPartition", "Format", ".ctor", "Initialize", ···]
Not found: "MethodToBeLoaded"
}
}

Expand Down
Loading