Skip to content

fix: profiling - unknown stacktraces on net8 #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vaind merged 7 commits into from
Mar 9, 2025
Merged

fix: profiling - unknown stacktraces on net8 #3967

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a2451c5
fix: unknown stacktraces on net8
vaind Feb 13, 2025
25c6734
chore: update changelog
vaind Feb 13, 2025
68c55c0
slacken test criteria
vaind Feb 13, 2025
faddc7d
Merge branch 'main' into fix/net8-unknown-stacktraces
vaind Feb 18, 2025
486ee52
chore: fixup changelog
vaind Feb 18, 2025
6f5e740
Merge branch 'main' into fix/net8-unknown-stacktraces
bruno-garcia Mar 8, 2025
f80ff56
add pr to changelog released in 5.2.0
bruno-garcia Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
slacken test criteria
  • Loading branch information
@vaind
vaind committed Feb 13, 2025
commit 68c55c09a4364f64453ea3d3d08e1672e840d913
4 changes: 1 addition & 3 deletions test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,11 @@ public async Task EventPipeSession_ReceivesExpectedCLREvents()
{
var eventsReceived = new HashSet<string>();
session!.EventSource.Clr.MethodLoadVerbose += (_) => eventsReceived.Add("Method/LoadVerbose");
session!.EventSource.Clr.MethodUnloadVerbose += (_) => eventsReceived.Add("Method/UnloadVerbose");
session!.EventSource.Clr.MethodILToNativeMap += (_) => eventsReceived.Add("Method/ILToNativeMap");

await session.WaitForFirstEventAsync(CancellationToken.None);
var tries = 0;
while (eventsReceived.Count < 3 && tries++ < 10)
while (eventsReceived.Count < 2 && tries++ < 10)
{
if (tries > 1)
{
Expand All @@ -213,7 +212,6 @@ public async Task EventPipeSession_ReceivesExpectedCLREvents()
}

Assert.Contains("Method/LoadVerbose", eventsReceived);
Assert.Contains("Method/UnloadVerbose", eventsReceived);
Assert.Contains("Method/ILToNativeMap", eventsReceived);
}
}
Expand Down
Loading