Fix fromjson serialization of breadcrumbs from android

[aritchie]

Resolves #3851 should also prevent issues from cocoa SDK as well

[jamescrosswell]

Looks good. Would be great if we could add some unit tests. I think these would only run on the Android Device tests but that's OK.

[aritchie]

@jamescrosswell I'm not sure how we would unit test these. Thoughts? The value coming from native is a string. I don't see anyway to simulate all error conditions from native at this time either.

[jamescrosswell]

@jamescrosswell I'm not sure how we would unit test these. Thoughts? The value coming from native is a string. I don't see anyway to simulate all error conditions from native at this time either.

We may not have bulletproof unit tests but perfect is the enemy of good, as they say.

Ultimately this method takes a JsonElement as input. It should be possible to test the method with various different inputs.

In the most basic case, that could be a JsonElement representing some JSON produced by the sentry-dotnet SDK when we serialize a breadcrumb.

For this particular change, it would also be good to test it with the JSON for a breadcrumb that had been serialised using the Native SDK. Worst case, we simply run one of our sample apps and capture that JSON in the console/debug logs then copy/paste into a test. Ideally we could run the most recent version of the Native code during the test to serialise one or more breadcrumbs to JSON and then parse that... which would ensure we were always testing against the JSON produced by the same version of the Native SDK that we embed with sentry-dotnet. Those would obviously have to be device tests.