-
-
Notifications
You must be signed in to change notification settings - Fork 226
feat: Added SentrySdk.CrashedLastRun
#4025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
SentrySdk.CrashedLastRun
| /// <summary> | ||
| /// The application did not crash during the last run. | ||
| /// </summary> | ||
| DidNotCrash, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In .NET (JIT-land) we might return DidNotCrash when in fact the app crashed natively. Since we don't capture native crashes when running on JIT on Windows/Mac/Linux. We do capture native crashes Native AOT, or JIT on Android, for example.
bruno-garcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we return true if the app crashed with an unhandled C# exception? (On Unity it keeps going, on .NET it crashes)
At first I thought it made sense adding this here too but now thinking to the fact we have this SDK running on UWP and all other weird runtimes where we can't confidently report on this status. It's prob best to keep it on Unity only for now.
|
So this would be a superset of the functionality provided by the native libraries (and wrapped in #3958)? As in, this would work for vanilla .NET applications as well? Also, presumably not relevant for server side apps (like ASP.NET Core)? |
The server could OOM and crash. And we'd say |
|
Since this came through a Unity SDK user and there we do have confidence in reporting the last run state there, I'm closing this in favour of getsentry/sentry-unity#2049 |
This came up through user feedback looking for functionality similar to AppCenter's
Crashes.GetLastSessionCrashReportAsync().Snippet on how to consume the API
Also resolves getsentry/sentry-unity#741