Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
228deef
Create MauiGestureRecognizerEventsBinder.cs
aritchie Apr 17, 2025
e66308c
Wireup
aritchie Apr 17, 2025
d2cb84f
Format code
getsentry-bot Apr 17, 2025
2eec158
WIP
aritchie Apr 17, 2025
24248da
Cleanup and fix code due stupid bot
aritchie Apr 17, 2025
98a9789
I'm not an animal - I can save mem
aritchie Apr 17, 2025
35e769c
Format code
getsentry-bot Apr 17, 2025
017f7f1
Command instrumentation
aritchie Apr 17, 2025
006abec
Format code
getsentry-bot Apr 17, 2025
f76f132
Fixes from live usage in our sample app
aritchie Apr 24, 2025
1943f22
Format code
getsentry-bot Apr 24, 2025
6687937
Update according to code review
aritchie Apr 30, 2025
751abe2
Merge branch 'main' into maui_ctmvvm
aritchie Apr 30, 2025
8059884
Update CHANGELOG.md
aritchie Apr 30, 2025
6586050
Update MauiGestureRecognizerEventsBinder.cs
aritchie Apr 30, 2025
d1d5089
Create MauiEventsBinderTests.GestureRecognizers.cs
aritchie Apr 30, 2025
efcd673
Update MauiEventsBinderTests.GestureRecognizers.cs
aritchie Apr 30, 2025
08a82bc
Merge branch 'main' into maui_gestures_breadcrumbs
aritchie Apr 30, 2025
4226806
Initial Unit Tests and samples
aritchie May 1, 2025
5752506
Merge branch 'main' into maui_ctmvvm
aritchie May 1, 2025
054041f
Merge branch 'main' into maui_gestures_breadcrumbs
aritchie May 1, 2025
1fba474
Update MauiEventsBinderTests.cs
aritchie May 1, 2025
118b627
Format code
getsentry-bot May 1, 2025
8ef9aca
Update CHANGELOG.md
aritchie May 1, 2025
559c8e0
Format code
getsentry-bot May 1, 2025
a71375a
WIP
aritchie May 1, 2025
ba54096
Merge branch 'maui_gestures_breadcrumbs' of https://github.com/getsen…
aritchie May 1, 2025
1a74296
add visual runner so I can test
aritchie May 2, 2025
90cbf1d
Merge branch 'main' into maui_ctmvvm
aritchie May 2, 2025
3af183a
Trying to add visual runner
aritchie May 2, 2025
e14e5c2
Merge branch 'main' into maui_gestures_breadcrumbs
aritchie May 2, 2025
66adf29
Update CHANGELOG.md
aritchie May 2, 2025
c55a364
Shelve so I can reset branch
aritchie May 6, 2025
86b25b9
Passing tests
aritchie May 6, 2025
587c137
generate slnf
aritchie May 6, 2025
c76ddec
Format code
getsentry-bot May 6, 2025
4e57733
Merge branch 'main' into maui_ctmvvm
aritchie May 6, 2025
6d8f86f
Finally fixed all build and test issues
aritchie May 6, 2025
7ed7f5c
Update CHANGELOG.md
aritchie May 6, 2025
490ad7b
Comment out visual runner for now
aritchie May 6, 2025
5b15d4d
Update Sentry.Maui.Device.TestApp.csproj
aritchie May 6, 2025
18c6e1f
Format code
getsentry-bot May 6, 2025
fe3fb27
Update device-test.ps1
aritchie May 6, 2025
afc5ea4
Merge branch 'maui_ctmvvm' of https://github.com/getsentry/sentry-dot…
aritchie May 6, 2025
dda6299
Update CtMvvmViewModel.cs
aritchie May 6, 2025
1a1f3b2
Update samples/Sentry.Samples.Maui/MauiProgram.cs
aritchie May 7, 2025
86079a3
Updates from PR review
aritchie May 7, 2025
394d12a
Merge branch 'maui_ctmvvm' of https://github.com/getsentry/sentry-dot…
aritchie May 7, 2025
12760df
Merge branch 'main' into maui_ctmvvm
aritchie May 7, 2025
23a9a00
Update CHANGELOG.md
aritchie May 7, 2025
67dde5f
Updated generated filters - added crashable app - some tests depend o…
aritchie May 7, 2025
f8dfca3
Format code
getsentry-bot May 7, 2025
b0393ac
Fixes
aritchie May 7, 2025
e7a5a9b
Merge branch 'main' into maui_gestures_breadcrumbs
aritchie May 9, 2025
d0c58f4
Bring over device tests to improve setup, fix gesture tests
aritchie May 9, 2025
039e35b
Merge branch 'maui_gestures_breadcrumbs' into maui_ctmvvm
aritchie May 9, 2025
0a08817
Update .generated.NoMobile.sln
aritchie May 9, 2025
4961411
Format code
getsentry-bot May 9, 2025
56e6d12
These run every time in the visual runner
aritchie May 9, 2025
ed4bb20
If working strictly from slnf - these don't get built and are depende…
aritchie May 9, 2025
a79dc8f
Finally got these to generate
aritchie May 9, 2025
ff6c52b
Format code
getsentry-bot May 9, 2025
c8d545c
Update MauiEventsBinderTests.GestureRecognizers.cs
aritchie May 9, 2025
b4f77b1
Merge branch 'maui_gestures_breadcrumbs' of https://github.com/getsen…
aritchie May 9, 2025
c10f2f0
Improve testing setup
aritchie May 9, 2025
19166b5
Merge branch 'maui_gestures_breadcrumbs' into maui_ctmvvm
aritchie May 9, 2025
8fa09e9
Update MauiEventsBinderTests.cs
aritchie May 9, 2025
4c1b584
Update api approval tests... again
aritchie May 9, 2025
28a4993
Update src/Sentry.Maui/Internal/MauiGestureRecognizerEventsBinder.cs
aritchie May 10, 2025
8e32be7
Merge branch 'main' into maui_gestures_breadcrumbs
aritchie May 10, 2025
28c2205
Update MauiGestureRecognizerEventsBinder.cs
aritchie May 10, 2025
44f30f8
Merge branch 'main' into maui_ctmvvm
aritchie May 10, 2025
dd29c1e
Merge branch 'maui_gestures_breadcrumbs' into maui_ctmvvm
aritchie May 10, 2025
bf8888a
Update src/Sentry.Maui.CommunityToolkit.Mvvm/MauiAppBuilderExtensions.cs
aritchie May 12, 2025
e73aa26
Renaming things
aritchie May 12, 2025
5115f0d
Merge branch 'main' into maui_ctmvvm
aritchie May 12, 2025
fd4c0f7
Update Directory.Build.props
aritchie May 12, 2025
e621044
Update MauiEventsBinderTests.cs
aritchie May 12, 2025
0cc439d
Simplified initialisation of the integration
jamescrosswell May 14, 2025
1488ad6
Merge branch 'main' into maui_ctmvvm
jamescrosswell May 14, 2025
62b56c2
Update CHANGELOG.md
jamescrosswell May 14, 2025
6d78d81
Format code
getsentry-bot May 14, 2025
78a934f
Update CtMvvmViewModel.cs
jamescrosswell May 14, 2025
931fb95
Update Sentry.csproj
jamescrosswell May 14, 2025
ecbab28
Update SentryMauiAppBuilderExtensions.cs
jamescrosswell May 14, 2025
52ef07a
Addressed thread safety concerns
jamescrosswell May 14, 2025
a2f3de9
Merge branch 'maui_ctmvvm' of github.com:getsentry/sentry-dotnet into…
jamescrosswell May 14, 2025
fec77a2
Format code
getsentry-bot May 14, 2025
167f9dc
Update MauiCommunityToolkitMvvmEventsBinder.cs
jamescrosswell May 15, 2025
04d35a8
Merge branch 'maui_ctmvvm' of github.com:getsentry/sentry-dotnet into…
jamescrosswell May 15, 2025
f1565c1
Target older version of CommunityToolkit.Mvvm
jamescrosswell May 15, 2025
77cd0cd
Created separate test project for new integration
jamescrosswell May 15, 2025
cb7b258
Workaround stale Scope.Transaction issue
jamescrosswell May 16, 2025
70525e6
Merge branch 'main' into maui_ctmvvm
bruno-garcia May 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Shelve so I can reset branch
  • Loading branch information
aritchie committed May 6, 2025
commit c55a3645ff5c8d9f09eaef8e6227bd0c963faa8d
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,12 @@
[Fact]
public async Task AsyncRelayCommand_AddsSpan()
{
var button = new Button();
var page = new ContentPage();
page.BindingContext = new TestCtMvvmViewModel();
//page.Content.AddLogicalChild(button);
var vm = new TestCtMvvmViewModel();
button.Command = vm.TestCommand;

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net8.0)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net8.0)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net9.0)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net9.0)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / ios-tests

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / ios-tests

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (ubuntu-22.04)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (ubuntu-22.04)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (ubuntu-22.04)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (ubuntu-22.04)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (windows-latest)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (windows-latest)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (windows-latest)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (windows-latest)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

The name 'button' does not exist in the current context

Check failure on line 14 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

The name 'button' does not exist in the current context

_fixture.Binder.OnApplicationOnDescendantAdded(null, new ElementEventArgs(page));
_fixture.Binder.OnApplicationOnDescendantAdded(null, new ElementEventArgs(button));

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net8.0)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net8.0)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net9.0)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net9.0)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / ios-tests

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / ios-tests

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (ubuntu-22.04)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (ubuntu-22.04)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (ubuntu-22.04)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (windows-latest)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (windows-latest)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (windows-latest)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

The name 'button' does not exist in the current context

Check failure on line 16 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

The name 'button' does not exist in the current context

// Act
button.RaiseEvent(nameof(Button.Clicked), EventArgs.Empty);
button.Command.Execute(null!);

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net8.0)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net8.0)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net9.0)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / Build (net9.0)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / ios-tests

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / ios-tests

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (ubuntu-22.04)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (ubuntu-22.04)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (ubuntu-22.04)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (windows-latest)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (windows-latest)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (windows-latest)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

The name 'button' does not exist in the current context

Check failure on line 18 in test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

View workflow job for this annotation

GitHub Actions / .NET (macos-15)

The name 'button' does not exist in the current context

// we need to wait for async command to run
await Task.Delay(TimeSpan.FromSeconds(1.1));
Expand Down
Loading